Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crt: onboard nomad-device-nvidia to crt #6

Merged
merged 4 commits into from
May 31, 2022
Merged

crt: onboard nomad-device-nvidia to crt #6

merged 4 commits into from
May 31, 2022

Conversation

shoenig
Copy link
Member

@shoenig shoenig commented Apr 25, 2022

This PR migrates to CRT.

But also it fixes the implementation to use itself rather than the package from an old version of nomad.

Sadly this also means using the new API which is generated from their original C code, which is of course all kinds breaking changes.

Seems to work ...

from nomad node status -self -verbose on my laptop

Device Group Attributes
Device Group     = nvidia/gpu/NVIDIA T1200 Laptop GPU
bar1             = 256 MiB
cores_clock      = 300 MHz
display_state    = 0
driver_version   = 470.103.01
memory_clock     = 405 MHz
memory           = 3914 MiB
pci_bandwidth    = 32768 MB/s
persistence_mode = 0
power            = 1 W

@shoenig shoenig marked this pull request as ready for review April 28, 2022 22:18
@shoenig shoenig requested review from lgfa29 and tgross April 28, 2022 22:19
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I don't have a test rig where I can run this plugin usefully right now, but the code looks good and it builds, which is enough to ship this I think. (Sorry for the delayed review! I missed a notification!)

CODEOWNERS Outdated Show resolved Hide resolved
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a few commits to standardize some parts of the release process across repos. I also had to disable OSV security scan for now due to the gopkg.in/yaml.v3 CVE (https://github.com/hashicorp/crt-workflows-common/runs/6663026851?check_suite_focus=true).

I think this will be gone once hashicorp/go-hclog#112 is released, so we can re-enable the check then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants