volume mount sandbox should protect against path traversal #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While this works in local development, it looks like TravisCI is broken with the current |
notnoop
approved these changes
Nov 11, 2020
picatz
approved these changes
Nov 11, 2020
|
Working on getting the build fixed in #22 |
The volume mounts for the LXC driver check that the path is not absolute, but a relative path can be passed as the source and that can be used to escape the task directory sandbox in the case where `volumes_enabled` is false (not the default).
tgross
force-pushed
the
b_mount_sandbox
branch
from
14a5673
to
ee9b0a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The volume mounts for the LXC driver check that the path is not absolute, but
a relative path can be passed as the source and that can be used to escape the
task directory sandbox in the case where
volumes_enabledis false (not thedefault).
This issue was discovered while investigating hashicorp/nomad#9303