config: add logging option #118
Conversation
|
|
|
Hi @zyclonite. Thank you for your contribution. There is, however, a considerable overlapping with the PR #99. In addition to what you did here it's also streaming the logs back from the host journal into the plugin to expose it via nomad. If i understand well we would loose the nomad log feature with your PR and journald log driver? Maybe you can try your setup with a build from #99 to see if it satisfies your needs? |
|
hi @towe75 by default the i fear with just having the |
|
@zyclonite : yes, the tags feature is certainly nice. Actually it think that it should be up to the user to decide if he wants "journal only" or "journal plus nomad" logging. Duplicate logging wastes some cpu cycles and bytes after all. This means that we could combine your PR and #99 and add distinct logdriver options for the two modes (journald with/without nomad streaming). @drewbailey any opinion from your side? What is the actual docker driver behavior, would i loose nomad logging if i enable journald? |
|
@towe75 sound great, is it possible to run with workflow in the mean time so i can fix potential issues already? i did test it already in the environment but maybe i missed some linting issues |
zyclonite
force-pushed
the
add_logging_option
branch
from
41663b3
to
5a05fab
Compare
zyclonite
force-pushed
the
add_logging_option
branch
from
5a05fab
to
0338a4a
Compare
|
thank you for running the workflow, strangely i was not able to run |
|
@towe75 I believe the podman driver currently relies solely on reading from the allocation directory. In order to support Nomad I think allowing users to specify which driver they want in the meantime is ok, but we should make sure the limitations are called out. |
|
@drewbailey streaming logs is the reason for #99 :-) Please check the readme there, it gives a pro/con overview about logging options. This PR here would add one more variant: log to journal without logging to nomad. Whilst not often needed one might consider it because of io performance. |
|
or if somebody uses promtail or similar tools to collect all logs by default so there is no need for an additional stream ;) |
|
@zyclonite : actually i am using promtail as well. But it's still nice to be able to quickly browse an alloc in the nomad ui and see the latest logs. I'm playing with the idea for yet another side project related to nomad, logging and loki, see hashicorp/nomad#9211 . Maybe you want to join me in this adventure ;-) |
|
@towe75 good joice, i really like it we built our own orchestration ui and only fallback to the raw nomad ui if everything else breaks your project sounds like a great idea which definitely adds value |
|
@zyclonite i propose to change you PR to use a log_driver="journald_only". My branch adds then later the actual log_driver="journald" which includes nomad streaming. Is this fine for you or can you find a better value for this option? |
|
@towe75 in the docker driver there exists the if we would stick to a similar pattern it would make the migration between these two drivers easier for the user... |
|
Ah, nice. I was not aware of this option. That's certainly better. Let's go for it. So you allow only journald in combination with disabled log collection, right? I will implement the other half later in my branch. |
|
i have not yet touched that option but i would say it makes sense to do it like you suggested |
|
@zyclonite please check my commit fb9d52e . I merged your branch into #99 and also added the disable_log_collection driver option. It only needs a bit polishing and more tests. Maybe you want to give it a try in your environment to see if it does what you want? |
|
looks good at first sight, i will try to find some time to test it tomorrow |
|
@zyclonite : nice, thank you for the feedback, discussion and of course the contributed code. Closing |
support switching between available logging drivers and provide options