ui: apply new qunit linting rules to tests

Async tests should use  in integrations tests.
Acceptance tests are using Mirage and can't use
since we can't know the number of assertions.

ui/tests/acceptance/allocation-detail-test.js

@@ -1,3 +1,5 @@
+/* eslint-disable qunit/require-expect */
+/* Mirage fixtures are random so we can't expect a set number of assertions */
 import { run } from '@ember/runloop';
 import { currentURL } from '@ember/test-helpers';
 import { assign } from '@ember/polyfills';
@@ -49,6 +51,8 @@ module('Acceptance | allocation detail', function (hooks) {
   });
 
   test('it passes an accessibility audit', async function (assert) {
+    assert.expect(1);
+
     await a11yAudit(assert);
   });
 
@@ -204,6 +208,7 @@ module('Acceptance | allocation detail', function (hooks) {
 
     await Allocation.tasks.objectAt(0).clickLink();
 
+    // Make sure the allocation is pending in order to ensure there are no tasks
     assert.equal(
       currentURL(),
       `/allocations/${allocation.id}/${task.name}`,
@@ -251,7 +256,6 @@ module('Acceptance | allocation detail', function (hooks) {
   });
 
   test('when there are no tasks, an empty state is shown', async function (assert) {
-    // Make sure the allocation is pending in order to ensure there are no tasks
     allocation = server.create('allocation', 'withTaskWithPorts', {
       clientStatus: 'pending',
     });

ui/tests/acceptance/application-errors-test.js

@@ -18,6 +18,8 @@ module('Acceptance | application errors ', function (hooks) {
   });
 
   test('it passes an accessibility audit', async function (assert) {
+    assert.expect(1);
+
     server.pretender.get('/v1/nodes', () => [500, {}, null]);
     await ClientsList.visit();
     await a11yAudit(assert);

ui/tests/acceptance/behaviors/fs.js

@@ -1,3 +1,4 @@
+/* eslint-disable qunit/require-expect */
 import { test } from 'qunit';
 import { currentURL, visit } from '@ember/test-helpers';
 

ui/tests/acceptance/client-detail-test.js

@@ -1,3 +1,6 @@
+/* eslint-disable qunit/require-expect */
+/* eslint-disable qunit/no-conditional-assertions */
+/* Mirage fixtures are random so we can't expect a set number of assertions */
 import { currentURL, waitUntil, settled } from '@ember/test-helpers';
 import { assign } from '@ember/polyfills';
 import { module, test } from 'qunit';

ui/tests/acceptance/client-monitor-test.js

@@ -28,6 +28,8 @@ module('Acceptance | client monitor', function (hooks) {
   });
 
   test('it passes an accessibility audit', async function (assert) {
+    assert.expect(1);
+
     await ClientMonitor.visit({ id: node.id });
     await a11yAudit(assert);
   });

ui/tests/acceptance/clients-list-test.js

@@ -1,3 +1,4 @@
+/* eslint-disable qunit/require-expect */
 import { currentURL, settled } from '@ember/test-helpers';
 import { module, test } from 'qunit';
 import { setupApplicationTest } from 'ember-qunit';

ui/tests/acceptance/exec-test.js

@@ -1,3 +1,4 @@
+/* eslint-disable qunit/require-expect */
 import { module, skip, test } from 'qunit';
 import { currentURL, settled } from '@ember/test-helpers';
 import { setupApplicationTest } from 'ember-qunit';

ui/tests/acceptance/job-allocations-test.js

@@ -1,3 +1,4 @@
+/* eslint-disable qunit/require-expect */
 import { currentURL } from '@ember/test-helpers';
 import { module, test } from 'qunit';
 import { setupApplicationTest } from 'ember-qunit';

ui/tests/acceptance/job-clients-test.js

@@ -1,3 +1,4 @@
+/* eslint-disable qunit/require-expect */
 import { currentURL } from '@ember/test-helpers';
 import { module, test } from 'qunit';
 import { setupApplicationTest } from 'ember-qunit';
@@ -75,11 +76,13 @@ module('Acceptance | job clients', function (hooks) {
 
       ['createTime', 'modifyTime'].forEach((col) => {
         if (jobStatus === 'not scheduled') {
+          /* eslint-disable-next-line qunit/no-conditional-assertions */
           assert.equal(
             clientRow[col].text,
             '-',
             `row ${index} doesn't have ${col} tooltip`
           );
+          /* eslint-disable-next-line qunit/no-early-return */
           return;
         }
 

ui/tests/acceptance/job-definition-test.js

@@ -21,6 +21,8 @@ module('Acceptance | job definition', function (hooks) {
   });
 
   test('it passes an accessibility audit', async function (assert) {
+    assert.expect(1);
+
     await a11yAudit(assert, 'scrollable-region-focusable');
   });
 

ui/tests/acceptance/job-deployments-test.js

@@ -41,14 +41,16 @@ module('Acceptance | job deployments', function (hooks) {
   });
 
   test('it passes an accessibility audit', async function (assert) {
+    assert.expect(1);
+
     await Deployments.visit({ id: job.id });
     await a11yAudit(assert);
   });
 
   test('/jobs/:id/deployments should list all job deployments', async function (assert) {
     await Deployments.visit({ id: job.id });
 
-    assert.ok(
+    assert.equal(
       Deployments.deployments.length,
       deployments.length,
       'Each deployment gets a row in the timeline'

ui/tests/acceptance/job-detail-test.js

@@ -1,4 +1,5 @@
 /* eslint-disable ember/no-test-module-for */
+/* eslint-disable qunit/require-expect */
 import { currentURL } from '@ember/test-helpers';
 import { module, test } from 'qunit';
 import { setupApplicationTest } from 'ember-qunit';

ui/tests/acceptance/job-dispatch-test.js

@@ -1,4 +1,6 @@
 /* eslint-disable ember/no-test-module-for */
+/* eslint-disable qunit/require-expect */
+/* eslint-disable qunit/no-conditional-assertions */
 import { module, test } from 'qunit';
 import { setupApplicationTest } from 'ember-qunit';
 import { setupMirage } from 'ember-cli-mirage/test-support';

ui/tests/acceptance/job-evaluations-test.js

@@ -1,3 +1,4 @@
+/* eslint-disable qunit/require-expect */
 import { currentURL } from '@ember/test-helpers';
 import { module, test } from 'qunit';
 import { setupApplicationTest } from 'ember-qunit';

ui/tests/acceptance/job-run-test.js

@@ -56,6 +56,8 @@ module('Acceptance | job run', function (hooks) {
   });
 
   test('it passes an accessibility audit', async function (assert) {
+    assert.expect(1);
+
     await JobRun.visit();
     await a11yAudit(assert);
   });

ui/tests/acceptance/job-versions-test.js

@@ -1,3 +1,5 @@
+/* eslint-disable qunit/require-expect */
+/* eslint-disable qunit/no-conditional-assertions */
 import { currentURL } from '@ember/test-helpers';
 import { module, test } from 'qunit';
 import { setupApplicationTest } from 'ember-qunit';
@@ -36,7 +38,7 @@ module('Acceptance | job versions', function (hooks) {
   });
 
   test('/jobs/:id/versions should list all job versions', async function (assert) {
-    assert.ok(
+    assert.equal(
       Versions.versions.length,
       versions.length,
       'Each version gets a row in the timeline'

ui/tests/acceptance/jobs-list-test.js

@@ -1,3 +1,4 @@
+/* eslint-disable qunit/require-expect */
 import { currentURL } from '@ember/test-helpers';
 import { module, test } from 'qunit';
 import { setupApplicationTest } from 'ember-qunit';

ui/tests/acceptance/optimize-test.js

@@ -1,3 +1,5 @@
+/* eslint-disable qunit/require-expect */
+/* eslint-disable qunit/no-conditional-assertions */
 import { module, test } from 'qunit';
 import { setupApplicationTest } from 'ember-qunit';
 import { currentURL, visit } from '@ember/test-helpers';

ui/tests/acceptance/plugin-allocations-test.js

@@ -1,3 +1,4 @@
+/* eslint-disable qunit/require-expect */
 import { module, test } from 'qunit';
 import { currentURL } from '@ember/test-helpers';
 import { setupApplicationTest } from 'ember-qunit';

ui/tests/acceptance/plugin-detail-test.js

@@ -1,3 +1,4 @@
+/* eslint-disable qunit/require-expect */
 import { module, test } from 'qunit';
 import { currentURL } from '@ember/test-helpers';
 import { setupApplicationTest } from 'ember-qunit';

ui/tests/acceptance/plugins-list-test.js

@@ -1,3 +1,4 @@
+/* eslint-disable qunit/require-expect */
 import { currentURL } from '@ember/test-helpers';
 import { module, test } from 'qunit';
 import { setupApplicationTest } from 'ember-qunit';

ui/tests/acceptance/regions-test.js

@@ -1,3 +1,5 @@
+/* eslint-disable qunit/require-expect */
+/* eslint-disable qunit/no-conditional-assertions */
 import { currentURL } from '@ember/test-helpers';
 import { module, test } from 'qunit';
 import { setupApplicationTest } from 'ember-qunit';

ui/tests/acceptance/search-test.js

@@ -1,4 +1,5 @@
-/* eslint-disable ember-a11y-testing/a11y-audit-called */ // TODO
+/* eslint-disable ember-a11y-testing/a11y-audit-called */
+/* eslint-disable qunit/require-expect */
 import { module, test } from 'qunit';
 import { currentURL, triggerEvent, visit } from '@ember/test-helpers';
 import { setupApplicationTest } from 'ember-qunit';
@@ -114,7 +115,7 @@ module('Acceptance | search', function (hooks) {
       request.requestBody.includes('feature-detection-query')
     );
 
-    assert.ok(
+    assert.equal(
       featureDetectionQueries.length,
       1,
       'expect the feature detection query to only run once'

ui/tests/acceptance/server-detail-test.js

@@ -1,3 +1,4 @@
+/* eslint-disable qunit/require-expect */
 import { currentURL } from '@ember/test-helpers';
 import { module, test } from 'qunit';
 import { setupApplicationTest } from 'ember-qunit';

ui/tests/acceptance/server-monitor-test.js

@@ -27,6 +27,8 @@ module('Acceptance | server monitor', function (hooks) {
   });
 
   test('it passes an accessibility audit', async function (assert) {
+    assert.expect(1);
+
     await ServerMonitor.visit({ name: agent.name });
     await a11yAudit(assert);
   });

ui/tests/acceptance/servers-list-test.js

@@ -1,3 +1,4 @@
+/* eslint-disable qunit/require-expect */
 import { currentURL } from '@ember/test-helpers';
 import { module, test } from 'qunit';
 import { setupApplicationTest } from 'ember-qunit';

ui/tests/acceptance/task-detail-test.js

@@ -1,3 +1,4 @@
+/* eslint-disable qunit/require-expect */
 import { currentURL } from '@ember/test-helpers';
 import { module, test } from 'qunit';
 import { setupApplicationTest } from 'ember-qunit';

ui/tests/acceptance/task-group-detail-test.js

@@ -1,3 +1,5 @@
+/* eslint-disable qunit/require-expect */
+/* eslint-disable qunit/no-conditional-assertions */
 import { currentURL, settled } from '@ember/test-helpers';
 import { module, test } from 'qunit';
 import { setupApplicationTest } from 'ember-qunit';

ui/tests/acceptance/task-logs-test.js

@@ -1,3 +1,4 @@
+/* eslint-disable qunit/require-expect */
 import { currentURL } from '@ember/test-helpers';
 import { run } from '@ember/runloop';
 import { module, test } from 'qunit';

ui/tests/acceptance/token-test.js

@@ -30,6 +30,8 @@ module('Acceptance | tokens', function (hooks) {
   });
 
   test('it passes an accessibility audit', async function (assert) {
+    assert.expect(1);
+
     await Tokens.visit();
     await a11yAudit(assert);
   });

ui/tests/acceptance/topology-test.js

@@ -25,6 +25,8 @@ module('Acceptance | topology', function (hooks) {
   });
 
   test('it passes an accessibility audit', async function (assert) {
+    assert.expect(1);
+
     server.createList('node', 3);
     server.createList('allocation', 5);
 

ui/tests/acceptance/volume-detail-test.js

@@ -1,3 +1,4 @@
+/* eslint-disable qunit/require-expect */
 import { module, test } from 'qunit';
 import { currentURL } from '@ember/test-helpers';
 import { setupApplicationTest } from 'ember-qunit';

ui/tests/acceptance/volumes-list-test.js

@@ -1,3 +1,4 @@
+/* eslint-disable qunit/require-expect */
 import { currentURL, visit } from '@ember/test-helpers';
 import { module, test } from 'qunit';
 import { setupApplicationTest } from 'ember-qunit';

ui/tests/helpers/glimmer-factory.js

@@ -1,16 +1,22 @@
-// Used in glimmer component unit tests. Glimmer components should typically
-// be tested with integration tests, but occasionally individual methods or
-// properties have logic that isn't coupled to rendering or the DOM and can
-// be better tested in a unit fashion.
-//
-// Use like
-//
-// setupGlimmerComponentFactory(hooks, 'my-component')
-//
-// test('testing my component', function(assert) {
-//   const component = this.createComponent({ hello: 'world' });
-//   assert.equal(component.args.hello, 'world');
-// });
+/* eslint-disable qunit/no-commented-tests */
+// We comment test to show an example of how to use the factory function
+
+/* 
+  Used in glimmer component unit tests. Glimmer components should typically
+  be tested with integration tests, but occasionally individual methods or
+  properties have logic that isn't coupled to rendering or the DOM and can
+  be better tested in a unit fashion.
+
+  Use like
+
+  setupGlimmerComponentFactory(hooks, 'my-component')
+
+  test('testing my component', function(assert) {
+    const component = this.createComponent({ hello: 'world' });
+    assert.equal(component.args.hello, 'world');
+  });
+*/
+
 export default function setupGlimmerComponentFactory(hooks, componentKey) {
   hooks.beforeEach(function () {
     this.createComponent = glimmerComponentInstantiator(

ui/tests/helpers/module-for-job.js

@@ -1,3 +1,5 @@
+/* eslint-disable qunit/require-expect */
+/* eslint-disable qunit/no-conditional-assertions */
 import { currentURL } from '@ember/test-helpers';
 import { module, test } from 'qunit';
 import { setupApplicationTest } from 'ember-qunit';

ui/tests/integration/components/agent-monitor-test.js

@@ -52,6 +52,8 @@ module('Integration | Component | agent-monitor', function (hooks) {
   `;
 
   test('basic appearance', async function (assert) {
+    assert.expect(5);
+
     this.setProperties({
       level: 'info',
       client: { id: 'client1' },

ui/tests/integration/components/allocation-row-test.js

@@ -79,6 +79,8 @@ module('Integration | Component | allocation row', function (hooks) {
   });
 
   test('Allocation row shows warning when it requires drivers that are unhealthy on the node it is running on', async function (assert) {
+    assert.expect(2);
+
     const node = this.server.schema.nodes.first();
     const drivers = node.drivers;
     Object.values(drivers).forEach((driver) => {
@@ -113,6 +115,8 @@ module('Integration | Component | allocation row', function (hooks) {
   });
 
   test('Allocation row shows an icon indicator when it was preempted', async function (assert) {
+    assert.expect(2);
+
     const allocId = this.server.create('allocation', 'preempted').id;
     const allocation = await this.store.findRecord('allocation', allocId);
 
@@ -128,6 +132,8 @@ module('Integration | Component | allocation row', function (hooks) {
   });
 
   test('when an allocation is not running, the utilization graphs are omitted', async function (assert) {
+    assert.expect(8);
+
     this.setProperties({
       context: 'job',
       enablePolling: false,

ui/tests/integration/components/app-breadcrumbs-test.js

@@ -44,6 +44,8 @@ module('Integration | Component | app breadcrumbs', function (hooks) {
   });
 
   test('every breadcrumb is rendered correctly', async function (assert) {
+    assert.expect(2);
+
     this.breadcrumbs.set('breadcrumbs', commonCrumbs);
 
     await render(template);
@@ -60,6 +62,8 @@ module('Integration | Component | app breadcrumbs', function (hooks) {
   });
 
   test('when breadcrumbs are pending promises, an ellipsis is rendered', async function (assert) {
+    assert.expect(3);
+
     let resolvePromise;
     const promise = new RSVP.Promise((resolve) => {
       resolvePromise = resolve;

ui/tests/integration/components/attributes-table-test.js

@@ -28,6 +28,8 @@ module('Integration | Component | attributes table', function (hooks) {
   };
 
   test('should render a row for each key/value pair in a deep object', async function (assert) {
+    assert.expect(2);
+
     this.set('attributes', commonAttributes);
     await render(hbs`<AttributesTable @attributePairs={{attributes}} />`);