Skip to content

Commit

Permalink
update comments
Browse files Browse the repository at this point in the history
  • Loading branch information
kevinschoonover committed Dec 23, 2021
1 parent 6e73605 commit 06d71e5
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
1 change: 0 additions & 1 deletion command/agent/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -1352,7 +1352,6 @@ func parseMultipleIPTemplate(ipTmpl string) ([]string, error) {
return []string{}, fmt.Errorf("Unable to parse address template %q: %v", ipTmpl, err)
}

// TODO: deduplicate the parsed ips
ips := strings.Split(out, " ")
if len(ips) == 0 {
return []string{}, errors.New("No addresses found, please configure one.")
Expand Down
1 change: 0 additions & 1 deletion command/agent/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -883,7 +883,6 @@ func TestConfig_normalizeAddrs_IPv6Loopback(t *testing.T) {
// TestConfig_normalizeAddrs_MultipleInterface asserts that normalizeAddrs will
// handle normalizing multiple interfaces in a single protocol.
func TestConfig_normalizeAddrs_MultipleInterfaces(t *testing.T) {
// TODO: add test with go-sockaddr templates
testCases := []struct {
name string
addressConfig *Addresses
Expand Down
4 changes: 3 additions & 1 deletion command/agent/testagent.go
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,9 @@ func (a *TestAgent) start() (*Agent, error) {
if err != nil {
return agent, err
}
// TODO: change type or handle better

// TODO: investigate if there is a way to remove the requirement by updating test.
// Initial pass at implementing this is https://github.com/kevinschoonover/nomad/tree/tests.
a.Servers = httpServers
a.Server = &httpServers[0]
return agent, nil
Expand Down

0 comments on commit 06d71e5

Please sign in to comment.