Skip to content

Commit

Permalink
address review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
Mahmood Ali committed Jun 30, 2021
1 parent 68684fb commit 0762e55
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .changelog/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Nomad uses [`go-changelog`](https://github.com/hashicorp/go-changelog) to genera
To install, run the following command:

```
go get github.com/hashicorp/go-changelog/cmd/changelog-build
go install github.com/hashicorp/go-changelog/cmd/changelog-build@latest
```

## Developer Guide
Expand Down
16 changes: 8 additions & 8 deletions .changelog/changelog.tmpl
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
{{- if .NotesByType.feature }}
FEATURES:

{{range .NotesByType.feature -}}
* {{ template "note" . }}
{{ end -}}
{{- end -}}

{{- if index .NotesByType "breaking-change" -}}
BREAKING CHANGES:

Expand All @@ -14,14 +22,6 @@ SECURITY:
{{ end -}}
{{- end -}}

{{- if .NotesByType.feature }}
FEATURES:

{{range .NotesByType.feature -}}
* {{ template "note" . }}
{{ end -}}
{{- end -}}

{{- if .NotesByType.improvement }}
IMPROVEMENTS:

Expand Down
6 changes: 6 additions & 0 deletions contributing/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,12 @@ developers and reviewers confidence that the proper changes have been made:
* [New CLI command](checklist-command.md)
* [New RPC endpoint](checklist-rpc-endpoint.md)
Changelog management
---
See [the Changelog README.md](../.changelog/README.md#developer-guide) for details.
Tooling
---
Expand Down

0 comments on commit 0762e55

Please sign in to comment.