Skip to content

Commit

Permalink
Merge eccfac8 into backport/b-fix-kill-timeout-validation/widely-aler…
Browse files Browse the repository at this point in the history
…t-kodiak
  • Loading branch information
hc-github-team-nomad-core authored Jun 1, 2023
2 parents 073cc2e + eccfac8 commit 081b1e1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion nomad/structs/structs.go
Original file line number Diff line number Diff line change
Expand Up @@ -6738,7 +6738,7 @@ func (tg *TaskGroup) Validate(j *Job) error {

// Validate the group's Update Strategy does not conflict with the Task's kill_timeout for service type jobs
if isTypeService && tg.Update != nil {
// progress_deadline = 0 has a special meaning show it should not
// progress_deadline = 0 has a special meaning so it should not be
// validated against the task's kill_timeout.
if tg.Update.ProgressDeadline > 0 && task.KillTimeout > tg.Update.ProgressDeadline {
mErr.Errors = append(mErr.Errors, fmt.Errorf("Task %s has a kill timout (%s) longer than the group's progress deadline (%s)",
Expand Down

0 comments on commit 081b1e1

Please sign in to comment.