Merge b71440a into backport/eval-safe-delete-filter/constantly-ace-ma…

…ntis

command/eval_delete.go

@@ -57,7 +57,9 @@ Eval Delete Options:
   -filter
     Specifies an expression used to filter evaluations by for deletion. When
     using this flag, it is advisable to ensure the syntax is correct using the
-    eval list command first.
+    eval list command first. Note that deleting evals by filter is imprecise:
+    for sets of evals larger than a single raft log batch, evals can be inserted
+    behind the cursor and therefore be missed.
 
   -yes
     Bypass the confirmation prompt if an evaluation ID was not provided.

nomad/eval_endpoint.go

@@ -536,11 +536,11 @@ func (e *Eval) deleteEvalsByFilter(args *structs.EvalDeleteRequest) (int, uint64
 		return count, index, err
 	}
 
-// Note that deleting evals by filter is imprecise: For sets of evals larger
-// than a single batch eval inserts may occur behind the cursor and therefore
-// be missed. This imprecision is not considered to hurt this endpoint's
-// purpose of reducing pressure on servers during periods of heavy scheduling
-// activity.
+	// Note that deleting evals by filter is imprecise: For sets of evals larger
+	// than a single batch eval inserts may occur behind the cursor and therefore
+	// be missed. This imprecision is not considered to hurt this endpoint's
+	// purpose of reducing pressure on servers during periods of heavy scheduling
+	// activity.
 	snap, err := e.srv.State().Snapshot()
 	if err != nil {
 		return count, index, fmt.Errorf("failed to lookup state snapshot: %v", err)

website/content/docs/commands/eval/delete.mdx

@@ -36,7 +36,10 @@ When ACLs are enabled, this command requires a `management` token.
 ## Delete Options
 
 - `-filter`: Specifies an expression used to filter evaluations by for
-  deletion.
+  deletion. When using this flag, it is advisable to ensure the syntax is
+  correct using the eval list command first. Note that deleting evals by filter
+  is imprecise: for sets of evals larger than a single raft log batch, evals can
+  be inserted behind the cursor and therefore be missed.
 
 - `-yes`: Bypass the confirmation prompt if an evaluation ID was not provided.