Skip to content

Commit

Permalink
Filter out new records from the job list page
Browse files Browse the repository at this point in the history
When a prefix is set and the run job button is clicked,
the new job causes an error because it has no name yet.
  • Loading branch information
DingoEatingFuzz committed Jul 10, 2020
1 parent e8a8d08 commit 287e8ac
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
1 change: 1 addition & 0 deletions ui/app/controllers/jobs/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ export default class IndexController extends Controller.extend(Sortable, Searcha

return this.model
.compact()
.filter(job => !job.isNew)
.filter(job => !hasNamespaces || job.get('namespace.id') === activeNamespace)
.filter(job => !job.get('parent.content'));
}
Expand Down
14 changes: 14 additions & 0 deletions ui/tests/acceptance/jobs-list-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -452,5 +452,19 @@ module('Acceptance | jobs list', function(hooks) {
'URL has the correct query param key and value'
);
});

test('the run job button works when filters are set', async function(assert) {
['pre-one', 'pre-two', 'pre-three'].forEach(name => {
server.create('job', { name, createAllocations: false, childrenCount: 0 });
});

await JobsList.visit();

await JobsList.facets.prefix.toggle();
await JobsList.facets.prefix.options[0].toggle();

await JobsList.runJobButton.click();
assert.equal(currentURL(), '/jobs/run');
});
}
});

0 comments on commit 287e8ac

Please sign in to comment.