Skip to content

Commit

Permalink
Change compared page object to match by name
Browse files Browse the repository at this point in the history
I believe this test became flaky after #8833, you can see
an example failure here:
https://app.circleci.com/pipelines/github/hashicorp/nomad/11809/workflows/0dc3c8f4-187c-44af-8bdb-6f010d653081/jobs/100848

My understanding of the goal here is not to assert that the
first task group in the server database matches the first
row displayed, but that before #8833 it could be assumed
that they did match. This changes to find the row corresponding
to the first server task group instead of assuming it’ll
be first.
  • Loading branch information
backspace committed Sep 17, 2020
1 parent ea1204a commit 29652bd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ui/tests/acceptance/job-deployments-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ module('Acceptance | job deployments', function(hooks) {
);

const taskGroup = taskGroupSummaries[0];
const taskGroupRow = deploymentRow.taskGroups.objectAt(0);
const taskGroupRow = deploymentRow.taskGroups.findOneBy('name', taskGroup.name);

assert.equal(taskGroupRow.name, taskGroup.name, 'Name');
assert.equal(taskGroupRow.promotion, promotionTestForTaskGroup(taskGroup), 'Needs Promotion');
Expand Down

0 comments on commit 29652bd

Please sign in to comment.