QueryOptions.SetTimeToBlock should take pointer receiver

Fixes a bug where blocking queries that are retried don't have their blocking timeout reset, resulting in them running longer than expected.
hashicorp · Apr 18, 2022 · 334c258 · 334c258
1 parent 5628cae
commit 334c258
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/.changelog/12593.txt b/.changelog/12593.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+client: Fixed a bug where clients that retry blocking queries would not reset the correct blocking duration
+```
diff --git a/nomad/structs/structs.go b/nomad/structs/structs.go
@@ -296,7 +296,7 @@ func (q QueryOptions) TimeToBlock() time.Duration {
 	return q.MaxQueryTime
 }
 
-func (q QueryOptions) SetTimeToBlock(t time.Duration) {
+func (q *QueryOptions) SetTimeToBlock(t time.Duration) {
 	q.MaxQueryTime = t
 }