Skip to content

Commit

Permalink
When reserving ports don't reserve network interface speed
Browse files Browse the repository at this point in the history
  • Loading branch information
@dadgar
dadgar committed Apr 7, 2016
1 parent da54330 commit 36a7505
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions client/client.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -555,6 +555,7 @@ func (c *Client) reservePorts() {
res, ok := reservedIndex[net.IP]
if !ok {
res = net.Copy()
res.MBits = 0
reservedIndex[net.IP] = res
}

Expand Down

6 comments on commit 36a7505

@dennybaa
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't resolve #1046 and #1617 (at least in 0.4.1). Maybe it should resolve, however in my case allocation still fails and only removal of reserved_ports does the trick.

Anyways it would be nice to see the reason of particular failure, not just mitigation.

@dadgar
Copy link
Contributor Author

@dadgar dadgar commented on 36a7505 Mar 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dennybaa Can you try on 0.5.4? If you are on EC2 there was another bug that was fixed that could cause these issues: #1952

@dennybaa
Copy link

@dennybaa dennybaa commented on 36a7505 Mar 1, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dadgar Hi Alex, unfortunately no :( My setups don't work with 0.5. I will definitely check it, but as soon I'm unblocked with #1988 (which is also closed, though I've tried the new cluster with all nodes 0.5.5-rc1 - no luck).

@dennybaa
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and yes I'm on EC2

@dadgar
Copy link
Contributor Author

@dadgar dadgar commented on 36a7505 Mar 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dennybaa Yep sounds like you will just need to upgrade or not use reserved_ports. The other workaround would be to disable the AWS fingerprinter using: https://www.nomadproject.io/docs/agent/configuration/client.html#_quot_fingerprint_blacklist_quot_

@dennybaa
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dadgar Thank you for the details Alex, I will try that and ping you back as I can check the reserved_ports on the >~ 0.5.

Please sign in to comment.