Skip to content

Commit

Permalink
style: fix up very long tag word breaking the allocation service tabl…
Browse files Browse the repository at this point in the history
…e width (#11995)
  • Loading branch information
ttys3 committed Feb 5, 2022
1 parent 16485f4 commit 3fc7389
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
3 changes: 3 additions & 0 deletions .changelog/11995.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:improvement
ui: break long service tags into multiple lines
```
6 changes: 5 additions & 1 deletion ui/app/styles/core/table.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use "sass:math";
@use 'sass:math';

.table {
color: $text;
Expand Down Expand Up @@ -103,6 +103,10 @@
}
}

&.is-long-text {
word-break: break-word;
}

// Only use px modifiers when text needs to be truncated.
// In this and only this scenario are percentages not effective.
&.is-200px {
Expand Down
2 changes: 1 addition & 1 deletion ui/app/templates/allocations/allocation/index.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@
<tr data-test-service>
<td data-test-service-name>{{row.model.name}}</td>
<td data-test-service-port>{{row.model.portLabel}}</td>
<td data-test-service-tags>{{join ", " row.model.tags}}</td>
<td data-test-service-tags class="is-long-text">{{join ", " row.model.tags}}</td>
<td data-test-service-onupdate>{{row.model.onUpdate}}</td>
<td data-test-service-connect>{{if row.model.connect "Yes" "No"}}</td>
<td data-test-service-upstreams>
Expand Down

0 comments on commit 3fc7389

Please sign in to comment.