comment why we ignore errors parsing params

hashicorp · Jan 9, 2020 · 5517743 · 5517743
1 parent a1f464f
commit 5517743
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/command/agent/agent_endpoint.go b/command/agent/agent_endpoint.go
@@ -360,6 +360,8 @@ func (s *HTTPServer) AgentPprofRequest(resp http.ResponseWriter, req *http.Reque
 func (s *HTTPServer) agentPprof(reqType pprof.ReqType, resp http.ResponseWriter, req *http.Request) ([]byte, error) {
 
 	// Parse query param int values
+	// Errors are dropped here and default to their zero values.
+	// This is to mimick the functionality that net/pprof implements.
 	seconds, _ := strconv.Atoi(req.URL.Query().Get("seconds"))
 	debug, _ := strconv.Atoi(req.URL.Query().Get("debug"))
 	gc, _ := strconv.Atoi(req.URL.Query().Get("gc"))