Merge pull request #3603 from hashicorp/f-ui-placement-failures

UI Placement Failures & Evaluations

ui/app/controllers/jobs/job/index.js

@@ -30,6 +30,10 @@ export default Controller.extend(Sortable, WithNamespaceResetting, {
   listToSort: computed.alias('taskGroups'),
   sortedTaskGroups: computed.alias('listSorted'),
 
+  sortedEvaluations: computed('model.evaluations.@each.modifyIndex', function() {
+    return (this.get('model.evaluations') || []).sortBy('modifyIndex').reverse();
+  }),
+
   actions: {
     gotoTaskGroup(taskGroup) {
       this.transitionToRoute('jobs.job.task-group', taskGroup.get('job'), taskGroup);

ui/app/models/evaluation.js

@@ -0,0 +1,27 @@
+import Ember from 'ember';
+import Model from 'ember-data/model';
+import attr from 'ember-data/attr';
+import { belongsTo } from 'ember-data/relationships';
+import { fragmentArray } from 'ember-data-model-fragments/attributes';
+import shortUUIDProperty from '../utils/properties/short-uuid';
+
+const { computed } = Ember;
+
+export default Model.extend({
+  shortId: shortUUIDProperty('id'),
+  priority: attr('number'),
+  type: attr('string'),
+  triggeredBy: attr('string'),
+  status: attr('string'),
+  statusDescription: attr('string'),
+  failedTGAllocs: fragmentArray('placement-failure', { defaultValue: () => [] }),
+
+  hasPlacementFailures: computed.bool('failedTGAllocs.length'),
+
+  // TEMPORARY: https://github.com/emberjs/data/issues/5209
+  originalJobId: attr('string'),
+
+  job: belongsTo('job'),
+
+  modifyIndex: attr('number'),
+});

ui/app/models/job.js

@@ -53,8 +53,35 @@ export default Model.extend({
   versions: hasMany('job-versions'),
   allocations: hasMany('allocations'),
   deployments: hasMany('deployments'),
+  evaluations: hasMany('evaluations'),
   namespace: belongsTo('namespace'),
 
+  hasPlacementFailures: computed.bool('latestFailureEvaluation'),
+
+  latestEvaluation: computed('evaluations.@each.modifyIndex', 'evaluations.isPending', function() {
+    const evaluations = this.get('evaluations');
+    if (!evaluations || evaluations.get('isPending')) {
+      return null;
+    }
+    return evaluations.sortBy('modifyIndex').get('lastObject');
+  }),
+
+  latestFailureEvaluation: computed(
+    'evaluations.@each.modifyIndex',
+    'evaluations.isPending',
+    function() {
+      const evaluations = this.get('evaluations');
+      if (!evaluations || evaluations.get('isPending')) {
+        return null;
+      }
+
+      const failureEvaluations = evaluations.filterBy('hasPlacementFailures');
+      if (failureEvaluations) {
+        return failureEvaluations.sortBy('modifyIndex').get('lastObject');
+      }
+    }
+  ),
+
   supportsDeployments: computed.equal('type', 'service'),
 
   runningDeployment: computed('deployments.@each.status', function() {

ui/app/models/placement-failure.js

@@ -0,0 +1,20 @@
+import attr from 'ember-data/attr';
+import Fragment from 'ember-data-model-fragments/fragment';
+
+export default Fragment.extend({
+  name: attr('string'),
+
+  coalescedFailures: attr('number'),
+
+  nodesEvaluated: attr('number'),
+  nodesExhausted: attr('number'),
+
+  // Maps keyed by relevant dimension (dc, class, constraint, etc) with count values
+  nodesAvailable: attr(),
+  classFiltered: attr(),
+  constraintFiltered: attr(),
+  classExhausted: attr(),
+  dimensionExhausted: attr(),
+  quotaExhausted: attr(),
+  scores: attr(),
+});

ui/app/models/task-group.js

@@ -24,6 +24,11 @@ export default Fragment.extend({
 
   reservedEphemeralDisk: attr('number'),
 
+  placementFailures: computed('job.latestFailureEvaluation.failedTGAllocs.[]', function() {
+    const placementFailures = this.get('job.latestFailureEvaluation.failedTGAllocs');
+    return placementFailures && placementFailures.findBy('name', this.get('name'));
+  }),
+
   queuedOrStartingAllocs: computed('summary.{queuedAllocs,startingAllocs}', function() {
     return this.get('summary.queuedAllocs') + this.get('summary.startingAllocs');
   }),

ui/app/routes/jobs/job.js

@@ -1,7 +1,7 @@
 import Ember from 'ember';
 import notifyError from 'nomad-ui/utils/notify-error';
 
-const { Route, inject } = Ember;
+const { Route, RSVP, inject } = Ember;
 
 export default Route.extend({
   store: inject.service(),
@@ -17,7 +17,7 @@ export default Route.extend({
     return this.get('store')
       .findRecord('job', fullId, { reload: true })
       .then(job => {
-        return job.get('allocations').then(() => job);
+        return RSVP.all([job.get('allocations'), job.get('evaluations')]).then(() => job);
       })
       .catch(notifyError(this));
   },

ui/app/serializers/evaluation.js

@@ -0,0 +1,27 @@
+import Ember from 'ember';
+import ApplicationSerializer from './application';
+
+const { inject, get, assign } = Ember;
+
+export default ApplicationSerializer.extend({
+  system: inject.service(),
+
+  normalize(typeHash, hash) {
+    hash.FailedTGAllocs = Object.keys(hash.FailedTGAllocs || {}).map(key => {
+      return assign({ Name: key }, get(hash, `FailedTGAllocs.${key}`) || {});
+    });
+
+    hash.PlainJobId = hash.JobID;
+    hash.Namespace =
+      hash.Namespace ||
+      get(hash, 'Job.Namespace') ||
+      this.get('system.activeNamespace.id') ||
+      'default';
+    hash.JobID = JSON.stringify([hash.JobID, hash.Namespace]);
+
+    // TEMPORARY: https://github.com/emberjs/data/issues/5209
+    hash.OriginalJobId = hash.JobID;
+
+    return this._super(typeHash, hash);
+  },
+});

ui/app/serializers/job.js

@@ -19,7 +19,7 @@ export default ApplicationSerializer.extend({
     // Transform the map-based JobSummary object into an array-based
     // JobSummary fragment list
     hash.TaskGroupSummaries = Object.keys(get(hash, 'JobSummary.Summary') || {}).map(key => {
-      const allocStats = get(hash, `JobSummary.Summary.${key}`);
+      const allocStats = get(hash, `JobSummary.Summary.${key}`) || {};
       const summary = { Name: key };
 
       Object.keys(allocStats).forEach(
@@ -65,6 +65,11 @@ export default ApplicationSerializer.extend({
           related: buildURL(`${jobURL}/deployments`, { namespace: namespace }),
         },
       },
+      evaluations: {
+        links: {
+          related: buildURL(`${jobURL}/evaluations`, { namespace: namespace }),
+        },
+      },
     });
   },
 });

ui/app/styles/components.scss

@@ -12,6 +12,7 @@
 @import "./components/loading-spinner";
 @import "./components/metrics";
 @import "./components/node-status-light";
+@import "./components/simple-list";
 @import "./components/status-text";
 @import "./components/timeline";
 @import "./components/tooltip";

ui/app/styles/components/simple-list.scss

@@ -0,0 +1,9 @@
+.simple-list {
+  list-style: disc;
+  list-style-position: inside;
+  margin-left: 1.5rem;
+
+  li {
+    margin-bottom: 0.5em;
+  }
+}

ui/app/templates/jobs/job/index.hbs

@@ -47,6 +47,57 @@
       </div>
     </div>
 
+    {{#if model.hasPlacementFailures}}
+      <div class="boxed-section is-danger placement-failures">
+        <div class="boxed-section-head">
+          Placement Failures
+        </div>
+        <div class="boxed-section-body">
+          {{#each model.taskGroups as |taskGroup|}}
+            {{#if taskGroup.placementFailures}}
+              {{#with taskGroup.placementFailures as |failures|}}
+                  <h3 class="title is-5">
+                    {{taskGroup.name}}
+                    <span class="badge is-light">{{inc failures.coalescedFailures}} unplaced</span>
+                  </h3>
+                  <ul class="simple-list">
+                    {{#if (eq failures.nodesEvaluated 0)}}
+                      <li>No nodes were eligible for evaluation</li>
+                    {{/if}}
+                    {{#each-in failures.nodesAvailable as |datacenter available|}}
+                      {{#if (eq available 0)}}
+                        <li>No nodes are available in datacenter {{datacenter}}</li>
+                      {{/if}}
+                    {{/each-in}}
+                    {{#each-in failures.classFiltered as |class count|}}
+                      <li>Class {{class}} filtered {{count}} {{pluralize "node" count}}</li>
+                    {{/each-in}}
+                    {{#each-in failures.constraintFiltered as |constraint count|}}
+                      <li>Constraint <code>{{constraint}}</code> filtered {{count}} {{pluralize "node" count}}</li>
+                    {{/each-in}}
+                    {{#if failures.nodesExhausted}}
+                      <li>Resources exhausted on {{failures.nodesExhausted}} {{pluralize "node" failures.nodesExhausted}}</li>
+                    {{/if}}
+                    {{#each-in failures.classExhausted as |class count|}}
+                      <li>Class {{class}} exhausted on {{count}} {{pluralize "node" count}}</li>
+                    {{/each-in}}
+                    {{#each-in failures.dimensionExhausted as |dimension count|}}
+                      <li>Dimension {{dimension}} exhausted on {{count}} {{pluralize "node" count}}</li>
+                    {{/each-in}}
+                    {{#each-in failures.quotaExhausted as |quota dimension|}}
+                      <li>Quota limit hit {{dimension}}</li>
+                    {{/each-in}}
+                    {{#each-in failures.scores as |name score|}}
+                      <li>Score {{name}} = {{score}}</li>
+                    {{/each-in}}
+                  </ul>
+              {{/with}}
+            {{/if}}
+          {{/each}}
+        </div>
+      </div>
+    {{/if}}
+
     {{#if model.runningDeployment}}
       <div class="boxed-section is-info active-deployment">
         <div class="boxed-section-head">
@@ -109,5 +160,39 @@
         {{/list-pagination}}
       </div>
     </div>
+
+    <div class="boxed-section">
+      <div class="boxed-section-head">
+        Evaluations
+      </div>
+      <div class="boxed-section-body is-full-bleed evaluations">
+        {{#list-table source=sortedEvaluations as |t|}}
+          {{#t.head}}
+            <th>ID</th>
+            <th>Priority</th>
+            <th>Triggered By</th>
+            <th>Status</th>
+            <th>Placement Failures</th>
+          {{/t.head}}
+          {{#t.body as |row|}}
+            <tr>
+              <td>{{row.model.shortId}}</td>
+              <td>{{row.model.priority}}</td>
+              <td>{{row.model.triggeredBy}}</td>
+              <td>{{row.model.status}}</td>
+              <td>
+                {{#if (eq row.model.status "blocked")}}
+                  N/A - In Progress
+                {{else if row.model.hasPlacementFailures}}
+                  True
+                {{else}}
+                  False
+                {{/if}}
+              </td>
+            </tr>
+          {{/t.body}}
+        {{/list-table}}
+      </div>
+    </div>
   </section>
 {{/gutter-menu}}

ui/mirage/common.js

@@ -71,7 +71,7 @@ function ipv6() {
   for (var i = 0; i < 8; i++) {
     var subnet = [];
     for (var char = 0; char < 4; char++) {
-      subnet.push(faker.random.number(16).toString(16));
+      subnet.push(faker.random.number(15).toString(16));
     }
     subnets.push(subnet.join(''));
   }

ui/mirage/config.js

@@ -59,6 +59,12 @@ export default function() {
 
   this.get('/deployment/:id');
 
+  this.get('/job/:id/evaluations', function({ evaluations }, { params }) {
+    return this.serialize(evaluations.where({ jobId: params.id }));
+  });
+
+  this.get('/evaluation/:id');
+
   this.get('/deployment/allocations/:id', function(schema, { params }) {
     const job = schema.jobs.find(schema.deployments.find(params.id).jobId);
     const allocations = schema.allocations.where({ jobId: job.id });