fix lock/unlock, address feedback

nomad/client_agent_endpoint.go

@@ -159,7 +159,7 @@ func (a *Agent) monitor(conn io.ReadWriteCloser) {
 		args.SetForwarded()
 	}
 
-	// Handle serverID not equal to ours including region forwarding
+	// Try to forward request to remote region/server
 	if args.ServerID != "" {
 		serverToFwd, err := a.forwardFor(args.ServerID, region)
 		if err != nil {

nomad/rpc.go

@@ -531,21 +531,22 @@ func (r *rpcHandler) forwardRegion(region, method string, args interface{}, repl
 func (r *rpcHandler) getServer(region, serverID string) (*serverParts, error) {
 	// Bail if we can't find any servers
 	r.peerLock.RLock()
+	defer r.peerLock.RUnlock()
+
 	servers := r.peers[region]
 	if len(servers) == 0 {
-		r.peerLock.RUnlock()
 		r.logger.Warn("no path found to region", "region", region)
 		return nil, structs.ErrNoRegionPath
 	}
 
-	// Lookup server by id or namedoes not exist in requested regiont
+	// Lookup server by id or name
 	for _, server := range servers {
 		if server.Name == serverID || server.ID == serverID {
 			return server, nil
 		}
 	}
 
-	return nil, fmt.Errorf("unknown nomad server %s", serverID)
+	return nil, fmt.Errorf("unknown Nomad server %s", serverID)
 }
 
 // streamingRpc creates a connection to the given server and conducts the