Skip to content

Commit

Permalink
structs missed applying a style change from the review
Browse files Browse the repository at this point in the history
  • Loading branch information
langmartin committed Apr 11, 2019
1 parent be2838d commit 658916e
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions nomad/structs/structs.go
Original file line number Diff line number Diff line change
Expand Up @@ -1813,7 +1813,7 @@ type ResourceDevices []*RequestedDevice
// COMPAT(0.10): Remove in 0.10
// Equals ResourceDevices as set keyed by Name
func (d *ResourceDevices) Equals(o *ResourceDevices) bool {
if d == nil && o == nil {
if d == o {
return true
}
if d == nil || o == nil {
Expand Down Expand Up @@ -2145,7 +2145,6 @@ func (r *RequestedDevice) Equals(o *RequestedDevice) bool {
}

// r.Constraints == o.Constraints, order sensitive
// REVIEW: should this be a set comparison?
if len(r.Constraints) != len(o.Constraints) {
return false
}
Expand Down

0 comments on commit 658916e

Please sign in to comment.