volume: Add the missing option propagation_mode (#15626)

hashicorp · Jan 30, 2023 · 69b08bb · 69b08bb
1 parent 031765b
commit 69b08bb
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/.changelog/15626.txt b/.changelog/15626.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+fix: Add the missing option propagation_mode for volume_mount
+```
diff --git a/client/allocrunner/taskrunner/volume_hook.go b/client/allocrunner/taskrunner/volume_hook.go
@@ -88,9 +88,10 @@ func (h *volumeHook) hostVolumeMountConfigurations(taskMounts []*structs.VolumeM
 		}
 
 		mcfg := &drivers.MountConfig{
-			HostPath: hostVolume.Path,
-			TaskPath: m.Destination,
-			Readonly: hostVolume.ReadOnly || req.ReadOnly || m.ReadOnly,
+			HostPath:        hostVolume.Path,
+			TaskPath:        m.Destination,
+			Readonly:        hostVolume.ReadOnly || req.ReadOnly || m.ReadOnly,
+			PropagationMode: m.PropagationMode,
 		}
 		mounts = append(mounts, mcfg)
 	}
@@ -180,9 +181,10 @@ func (h *volumeHook) prepareCSIVolumes(req *interfaces.TaskPrestartRequest, volu
 
 		for _, m := range mountsForAlias {
 			mcfg := &drivers.MountConfig{
-				HostPath: csiMountPoint.Source,
-				TaskPath: m.Destination,
-				Readonly: request.ReadOnly || m.ReadOnly,
+				HostPath:        csiMountPoint.Source,
+				TaskPath:        m.Destination,
+				Readonly:        request.ReadOnly || m.ReadOnly,
+				PropagationMode: m.PropagationMode,
 			}
 			mounts = append(mounts, mcfg)
 		}

diff --git a/website/content/docs/job-specification/volume_mount.mdx b/website/content/docs/job-specification/volume_mount.mdx
@@ -26,6 +26,7 @@ job "docs" {
       volume_mount {
         volume      = "certs"
         destination = "/etc/ssl/certs"
+        propagation_mode = "private"
       }
     }
   }