Rename property for AttributesTable

There was a conflict between this being called attributes and the splattributes that are available for Glimmer components.
hashicorp · Jul 10, 2020 · 6fec3f2 · 6fec3f2
1 parent ed29e5e
commit 6fec3f2
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/ui/app/templates/clients/client/index.hbs b/ui/app/templates/clients/client/index.hbs
@@ -431,7 +431,7 @@
             {{#if a.item.attributes.attributesStructured}}
               <div class="boxed-section-body is-full-bleed">
                 <AttributesTable
-                  @attributes={{a.item.attributesShort}}
+                  @attributePairs={{a.item.attributesShort}}
                   @class="attributes-table" />
               </div>
             {{else}}
@@ -454,7 +454,7 @@
     <div class="boxed-section-body is-full-bleed">
       <AttributesTable
         data-test-attributes
-        @attributes={{this.model.attributes.attributesStructured}}
+        @attributePairs={{this.model.attributes.attributesStructured}}
         @class="attributes-table" />
     </div>
     <div class="boxed-section-head">
@@ -464,7 +464,7 @@
       <div class="boxed-section-body is-full-bleed">
         <AttributesTable
           data-test-meta
-          @attributes={{this.model.meta.attributesStructured}}
+          @attributePairs={{this.model.meta.attributesStructured}}
           @class="attributes-table" />
       </div>
     {{else}}

diff --git a/ui/app/templates/components/attributes-table.hbs b/ui/app/templates/components/attributes-table.hbs
@@ -6,6 +6,6 @@
     </tr>
   </thead>
   <tbody>
-    <AttributesSection @attributes={{this.attributes}} />
+    <AttributesSection @attributes={{@attributePairs}} />
   </tbody>
 </table>
diff --git a/ui/stories/components/table-configuration.stories.js b/ui/stories/components/table-configuration.stories.js
@@ -8,7 +8,7 @@ export let TableConfiguration = () => {
   return {
     template: hbs`
       <h5 class="title is-5">Table, configuration</h5>
-      <AttributesTable @attributes={{attributes}} @class="attributes-table" />
+      <AttributesTable @attributePairs={{attributes}} @class="attributes-table" />
       `,
     context: {
       attributes: {

diff --git a/ui/tests/integration/attributes-table-test.js b/ui/tests/integration/attributes-table-test.js
@@ -28,7 +28,7 @@ module('Integration | Component | attributes table', function(hooks) {
 
   test('should render a row for each key/value pair in a deep object', async function(assert) {
     this.set('attributes', commonAttributes);
-    await render(hbs`<AttributesTable @attributes={{attributes}} />`);
+    await render(hbs`<AttributesTable @attributePairs={{attributes}} />`);
 
     const rowsCount = Object.keys(flatten(commonAttributes)).length;
     assert.equal(
@@ -40,7 +40,7 @@ module('Integration | Component | attributes table', function(hooks) {
 
   test('should render the full path of key/value pair from the root of the object', async function(assert) {
     this.set('attributes', commonAttributes);
-    await render(hbs`<AttributesTable @attributes={{attributes}} />`);
+    await render(hbs`<AttributesTable @attributePairs={{attributes}} />`);
 
     assert.equal(find('[data-test-key]').textContent.trim(), 'key', 'Row renders the key');
     assert.equal(find('[data-test-value]').textContent.trim(), 'value', 'Row renders the value');
@@ -61,7 +61,7 @@ module('Integration | Component | attributes table', function(hooks) {
 
   test('should render a row for key/value pairs even when the value is another object', async function(assert) {
     this.set('attributes', commonAttributes);
-    await render(hbs`<AttributesTable @attributes={{attributes}} />`);
+    await render(hbs`<AttributesTable @attributePairs={{attributes}} />`);
 
     const countOfParentRows = countOfParentKeys(commonAttributes);
     assert.equal(