refact: add parent check to boolean (#14115)

* refact: add parent check to boolean * chore: add changelog entry
hashicorp · Aug 15, 2022 · 7079692 · 7079692
1 parent 9f51a5d
commit 7079692
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/.changelog/14115.txt b/.changelog/14115.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+ui: Removes duplicate breadcrumb header when navigating from child job back to parent.
+```
diff --git a/ui/app/components/breadcrumbs/job.hbs b/ui/app/components/breadcrumbs/job.hbs
@@ -8,7 +8,7 @@
     </li>
   {{/if}}
   {{#if trigger.data.isSuccess}}
-    {{#if trigger.data.result}}
+    {{#if (and trigger.data.result this.hasParent)}}
       <li>
         <LinkTo
           @route="jobs.job.index"

diff --git a/ui/app/components/breadcrumbs/job.js b/ui/app/components/breadcrumbs/job.js
@@ -7,15 +7,18 @@ export default class BreadcrumbsJob extends Component {
     return this.args.crumb.job;
   }
 
+  get hasParent() {
+    return !!this.job.belongsTo('parent').id();
+  }
+
   @action
   onError(err) {
     assert(`Error:  ${err.message}`);
   }
 
   @action
   fetchParent() {
-    const hasParent = !!this.job.belongsTo('parent').id();
-    if (hasParent) {
+    if (this.hasParent) {
       return this.job.get('parent');
     }
   }