simplify canary check

`(alloc.DeploymentStatus == nil || !alloc.DeploymentStatus.IsCanary())` and `!alloc.DeploymentStatus.IsCanary()` are equivalent.
hashicorp · Aug 25, 2020 · 7275650 · 7275650
1 parent 3fef220
commit 7275650
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/scheduler/reconcile.go b/scheduler/reconcile.go
@@ -723,7 +723,7 @@ func (a *allocReconciler) computePlacements(group *structs.TaskGroup,
 			reschedule:    true,
 			canary:        alloc.DeploymentStatus.IsCanary(),
 
-			downgradeNonCanary: canaryState && (alloc.DeploymentStatus == nil || !alloc.DeploymentStatus.IsCanary()),
+			downgradeNonCanary: canaryState && !alloc.DeploymentStatus.IsCanary(),
 			minJobVersion:      alloc.Job.Version,
 		})
 	}