Backport of fix(#13844): canonicalize job to avoid nil pointer defere…

…nce into release/1.3.x (#16016) This pull request was automerged via backport-assistant
hashicorp · Feb 1, 2023 · 7997107 · 7997107
1 parent 97f60a3
commit 7997107
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/.changelog/13845.txt b/.changelog/13845.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+api: Fixed a nil pointer dereference when periodic jobs are missing their periodic spec
+```
diff --git a/api/jobs.go b/api/jobs.go
@@ -800,7 +800,7 @@ func (p *PeriodicConfig) Canonicalize() {
 // returned. The `time.Location` of the returned value matches that of the
 // passed time.
 func (p *PeriodicConfig) Next(fromTime time.Time) (time.Time, error) {
-	if *p.SpecType == PeriodicSpecCron {
+	if p != nil && *p.SpecType == PeriodicSpecCron {
 		e, err := cronexpr.Parse(*p.Spec)
 		if err != nil {
 			return time.Time{}, fmt.Errorf("failed parsing cron expression %q: %v", *p.Spec, err)