Skip to content

Commit

Permalink
drainer: fix codec race condition in integration test (#16845)
Browse files Browse the repository at this point in the history
msgpackrpc codec handles are specific to a connection and cannot be shared
between goroutines; this can cause corrupted decoding. Fix the drainer
integration test so that we create separate codecs for the goroutines that the
test helper spins up to simulate client updates.

This changeset also refactors the drainer integration test to bring it up to
current idioms and library usages, make assertions more clear, and reduce
duplication.
  • Loading branch information
tgross committed Apr 11, 2023
1 parent fc75e9d commit 80bd521
Showing 1 changed file with 310 additions and 550 deletions.
Loading

0 comments on commit 80bd521

Please sign in to comment.