nomad state store must be modified through raft, rm local state change

nomad/state/state_store.go

@@ -3569,7 +3569,6 @@ func (s *StateStore) updateDeploymentWithAlloc(index uint64, alloc, existing *st
 		alloc.DeploymentStatus.ModifyIndex = index
 	}
 
-
 	// Create a copy of the deployment object
 	deploymentCopy := deployment.Copy()
 	deploymentCopy.ModifyIndex = index
@@ -3580,18 +3579,17 @@ func (s *StateStore) updateDeploymentWithAlloc(index uint64, alloc, existing *st
 	state.UnhealthyAllocs += unhealthy
 
 	// Ensure PlacedCanaries accurately reflects the alloc canary status
-	if alloc.DeploymentStatus != nil {
-		if alloc.DeploymentStatus.Canary {
-			found := false
-			for _, canary := range state.PlacedCanaries {
-				if alloc.ID == canary {
-					found = true
-				}
-			}
-			if !found {
-				state.PlacedCanaries = append(state.PlacedCanaries, alloc.ID)
+	if alloc.DeploymentStatus != nil && alloc.DeploymentStatus.Canary {
+		found := false
+		for _, canary := range state.PlacedCanaries {
+			if alloc.ID == canary {
+				found = true
+				break
 			}
 		}
+		if !found {
+			state.PlacedCanaries = append(state.PlacedCanaries, alloc.ID)
+		}
 	}
 
 	// Update the progress deadline

scheduler/generic_sched.go

@@ -529,10 +529,6 @@ func (s *GenericScheduler) computePlacements(destructive, place []placementResul
 				// If we are placing a canary and we found a match, add the canary
 				// to the deployment state object and mark it as a canary.
 				if missing.Canary() && s.deployment != nil {
-					if state, ok := s.deployment.TaskGroups[tg.Name]; ok {
-						state.PlacedCanaries = append(state.PlacedCanaries, alloc.ID)
-					}
-
 					alloc.DeploymentStatus = &structs.AllocDeploymentStatus{
 						Canary: true,
 					}