Skip to content

Commit

Permalink
Job editing and planning handles namespace as part of ID instead of q…
Browse files Browse the repository at this point in the history
…ueryParam
  • Loading branch information
philrenaud committed Jul 5, 2022
1 parent a3b3b54 commit 896837c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions ui/app/controllers/jobs/job/definition.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,15 @@ import Controller from '@ember/controller';
import WithNamespaceResetting from 'nomad-ui/mixins/with-namespace-resetting';
import { alias } from '@ember/object/computed';
import classic from 'ember-classic-decorator';
import { inject as service } from '@ember/service';

@classic
export default class DefinitionController extends Controller.extend(
WithNamespaceResetting
) {
@alias('model.job') job;
@alias('model.definition') definition;
@service router;

isEditing = false;

Expand All @@ -21,9 +23,7 @@ export default class DefinitionController extends Controller.extend(
this.set('isEditing', false);
}

onSubmit(id, jobNamespace) {
this.transitionToRoute('jobs.job', id, {
queryParams: { jobNamespace },
});
onSubmit() {
this.router.transitionTo('jobs.job', this.job.idWithNamespace);
}
}
6 changes: 3 additions & 3 deletions ui/app/controllers/jobs/run.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import Controller from '@ember/controller';
import { inject as service } from '@ember/service';

export default class RunController extends Controller {
@service router;
onSubmit(id, namespace) {
this.transitionToRoute('jobs.job', id, {
queryParams: { namespace },
});
this.router.transitionTo('jobs.job', `${id}@${namespace || 'default'}`);
}
}

0 comments on commit 896837c

Please sign in to comment.