Skip to content

Commit

Permalink
Merge pull request #11416 from hashicorp/f-rejected-info
Browse files Browse the repository at this point in the history
core: bump rejected plans from debug -> info
  • Loading branch information
schmichael authored and lgfa29 committed Nov 15, 2021
1 parent b9b8fa9 commit 91baa00
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .changelog/11416.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:improvement
core: Elevated rejected node plan log lines to help diagnose #9506
```
9 changes: 8 additions & 1 deletion nomad/plan_apply.go
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,14 @@ func evaluatePlanPlacements(pool *EvaluatePool, snap *state.StateSnapshot, plan
if !fit {
// Log the reason why the node's allocations could not be made
if reason != "" {
logger.Debug("plan for node rejected", "node_id", nodeID, "reason", reason, "eval_id", plan.EvalID)
//TODO This was debug level and should return
//to debug level in the future. However until
//https://github.com/hashicorp/nomad/issues/9506
//is resolved this log line is the only way to
//monitor the disagreement between workers and
//the plan applier.
logger.Info("plan for node rejected, refer to https://www.nomadproject.io/s/port-plan-failure for more information",
"node_id", nodeID, "reason", reason, "eval_id", plan.EvalID)
}
// Set that this is a partial commit
partialCommit = true
Expand Down
8 changes: 8 additions & 0 deletions website/redirects.js
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,14 @@ module.exports = [
permanent: true,
},

// /s/* redirects for useful links that need a stable URL but we may need to
// change its destination in the future.
{
source: '/s/port-plan-failure',
destination: 'https://github.com/hashicorp/nomad/issues/9506',
permanent: false,
},

// Spark guide links are all repointed to deprecated nomad-spark repo
{
source: '/guides/spark',
Expand Down

0 comments on commit 91baa00

Please sign in to comment.