Skip to content

Commit

Permalink
Remove superfluous test attributes
Browse files Browse the repository at this point in the history
I found while working on #5926 that x-icon already adds
assertion-compatible selectors, so these wrappers are
unnecessary.
  • Loading branch information
backspace committed Jul 5, 2019
1 parent 42a53ff commit 926825b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion ui/app/templates/allocations/allocation/task/fs.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
<tbody>
<tr data-test-entry>
<td colspan="3">
<span data-test-empty-icon>{{x-icon "alert-circle-outline"}}</span>
{{x-icon "alert-circle-outline"}}
<span class="name" data-test-name>Directory is empty</span>
</td>
</tr>
Expand Down
4 changes: 2 additions & 2 deletions ui/app/templates/components/fs-directory-entry.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
<td>
{{#link-to "allocations.allocation.task.fs" task.allocation task pathToEntry activeClass="is-active"}}
{{#if entry.IsDir}}
<span data-test-directory-icon>{{x-icon "folder-outline"}}</span>
{{x-icon "folder-outline"}}
{{else}}
<span data-test-file-icon>{{x-icon "file-outline"}}</span>
{{x-icon "file-outline"}}
{{/if}}

<span class="name" data-test-name>{{entry.Name}}</span>
Expand Down
6 changes: 3 additions & 3 deletions ui/tests/pages/allocations/task/fs.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ export default create({
directoryEntries: collection('[data-test-entry]', {
name: text('[data-test-name]'),

isFile: isPresent('[data-test-file-icon]'),
isDirectory: isPresent('[data-test-directory-icon]'),
isEmpty: isPresent('[data-test-empty-icon]'),
isFile: isPresent('.icon-is-file-outline'),
isDirectory: isPresent('.icon-is-folder-outline'),
isEmpty: isPresent('.icon-is-alert-circle-outline'),

size: text('[data-test-size]'),
lastModified: text('[data-test-last-modified]'),
Expand Down

0 comments on commit 926825b

Please sign in to comment.