Skip to content

Commit

Permalink
cni: fix assertion ordering in tests with multiple node networks
Browse files Browse the repository at this point in the history
  • Loading branch information
nickethier committed May 1, 2020
1 parent d858411 commit 9c626ce
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
7 changes: 4 additions & 3 deletions client/client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1263,7 +1263,7 @@ func Test_UpdateNodeFromFingerprintMultiIP(t *testing.T) {
// Client without network configured updates to match fingerprint
client, cleanup := TestClient(t, func(c *config.Config) {
c.NetworkInterface = dev
c.Node.NodeResources.Networks[0].Device = dev
c.Options["fingerprint.blacklist"] = "network,cni,bridge"
c.Node.Resources.Networks = c.Node.NodeResources.Networks
})
defer cleanup()
Expand All @@ -1278,12 +1278,13 @@ func Test_UpdateNodeFromFingerprintMultiIP(t *testing.T) {
},
})

two := structs.Networks{
nets := structs.Networks{
mock.Node().NodeResources.Networks[0],
{Device: dev, IP: "127.0.0.1"},
{Device: dev, IP: "::1"},
}

require.Equal(t, two, client.config.Node.NodeResources.Networks)
require.Equal(t, nets, client.config.Node.NodeResources.Networks)
}

func TestClient_computeAllocatedDeviceStats(t *testing.T) {
Expand Down
5 changes: 4 additions & 1 deletion client/fingerprint/cni_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,10 @@ func TestCNIFingerprint(t *testing.T) {
require.Contains(err.Error(), c.errMatch)
} else {
require.NoError(err)
require.Exactly(c.exp, resp)
require.Equal(c.exp.Detected, resp.Detected)
if resp.NodeResources != nil || c.exp.NodeResources != nil {
require.ElementsMatch(c.exp.NodeResources.Networks, resp.NodeResources.Networks)
}
}
})
}
Expand Down
2 changes: 1 addition & 1 deletion client/fingerprint/env_aws.go
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ func (f *EnvAWSFingerprint) Fingerprint(request *FingerprintRequest, response *F
response.AddAttribute("unique.network.ip-address", val)

newNetwork := &structs.NetworkResource{
Mode: "host",
Mode: "host",
Device: "eth0",
IP: val,
CIDR: val + "/32",
Expand Down

0 comments on commit 9c626ce

Please sign in to comment.