PR feedback

.changelog/16274.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+ui: fixed an issue where system/sysbatch jobs with wildcard datacenters (like ["dc*"]) were not showing client status charts
+```

ui/app/abilities/variable.js

@@ -2,7 +2,7 @@
 import { computed, get } from '@ember/object';
 import { or } from '@ember/object/computed';
 import AbstractAbility from './abstract';
-import { default as doesMatchPattern } from 'nomad-ui/utils/match-glob';
+import doesMatchPattern from 'nomad-ui/utils/match-glob';
 
 const WILDCARD_GLOB = '*';
 const WILDCARD_PATTERN = '/';
@@ -208,42 +208,6 @@ export default class Variable extends AbstractAbility {
     return this._smallestDifference(allMatchingPaths, path);
   }
 
-  // _doesMatchPattern(pattern, path) {
-  //   const parts = pattern?.split(WILDCARD_GLOB);
-  //   const hasLeadingGlob = pattern?.startsWith(WILDCARD_GLOB);
-  //   const hasTrailingGlob = pattern?.endsWith(WILDCARD_GLOB);
-  //   const lastPartOfPattern = parts[parts.length - 1];
-  //   const isPatternWithoutGlob = parts.length === 1 && !hasLeadingGlob;
-
-  //   if (!pattern || !path || isPatternWithoutGlob) {
-  //     return pattern === path;
-  //   }
-
-  //   if (pattern === WILDCARD_GLOB) {
-  //     return true;
-  //   }
-
-  //   let subPathToMatchOn = path;
-  //   for (let i = 0; i < parts.length; i++) {
-  //     const part = parts[i];
-  //     const idx = subPathToMatchOn?.indexOf(part);
-  //     const doesPathIncludeSubPattern = idx > -1;
-  //     const doesMatchOnFirstSubpattern = idx === 0;
-
-  //     if (i === 0 && !hasLeadingGlob && !doesMatchOnFirstSubpattern) {
-  //       return false;
-  //     }
-
-  //     if (!doesPathIncludeSubPattern) {
-  //       return false;
-  //     }
-
-  //     subPathToMatchOn = subPathToMatchOn.slice(0, idx + path.length);
-  //   }
-
-  //   return hasTrailingGlob || path.endsWith(lastPartOfPattern);
-  // }
-
   _computeLengthDiff(pattern, path) {
     const countGlobsInPattern = pattern
       ?.split('')

ui/app/utils/properties/job-client-status.js

@@ -27,9 +27,9 @@ export default function jobClientStatus(nodesKey, jobKey) {
 
       // Filter nodes by the datacenters defined in the job.
       const filteredNodes = nodes.filter((n) => {
-        return job.datacenters.filter((dc) => {
+        return job.datacenters.find((dc) => {
           return !!matchGlob(dc, n.datacenter);
-        }).length;
+        });
       });
 
       if (job.status === 'pending') {