Merge pull request #604 from hashicorp/f-port-err-msg

Throwing an error if ports are not named instead of crashing while parsing a job spec
hashicorp · Dec 18, 2015 · a3af91a · a3af91a
2 parents 9daeae7 + 6810791
commit a3af91a
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/jobspec/parse.go b/jobspec/parse.go
@@ -623,6 +623,9 @@ func parsePorts(networkObj *ast.ObjectList, nw *structs.NetworkResource) error {
 	portsObjList := networkObj.Filter("port")
 	knownPortLabels := make(map[string]bool)
 	for _, port := range portsObjList.Items {
+		if len(port.Keys) == 0 {
+			return fmt.Errorf("Ports must be named")
+		}
 		label := port.Keys[0].Token.Value().(string)
 		if !reDynamicPorts.MatchString(label) {
 			return errPortLabel