Skip to content

Commit

Permalink
Remove template-only component setting
Browse files Browse the repository at this point in the history
The ClientDetail.attributesTable assertion was failing because
it becoming a template-only component meant that the
data-test-attributes selector had no element to attach to.

Having the edition set to Octane in package.json causes an error
to be thrown when template-only-glimmer-components is turned
off, so it’ll have to go for now.
  • Loading branch information
backspace committed Jun 30, 2020
1 parent e3cd274 commit a448be8
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
2 changes: 1 addition & 1 deletion ui/config/optional-features.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"application-template-wrapper": false,
"default-async-observers": true,
"jquery-integration": false,
"template-only-glimmer-components": true
"template-only-glimmer-components": false
}
3 changes: 0 additions & 3 deletions ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,6 @@
"engines": {
"node": "10.* || >= 12"
},
"ember": {
"edition": "octane"
},
"private": true,
"ember-addon": {
"paths": [
Expand Down

0 comments on commit a448be8

Please sign in to comment.