Skip to content

Commit

Permalink
ui: fix action call to set filter query param
Browse files Browse the repository at this point in the history
  • Loading branch information
lgfa29 committed Dec 18, 2021
1 parent efd05ea commit a8c9676
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 7 deletions.
1 change: 0 additions & 1 deletion ui/app/controllers/clients/client/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,6 @@ export default class ClientController extends Controller.extend(Sortable, Search
return ns.sort().map(n => ({ key: n, label: n }));
}

@action
setFacetQueryParam(queryParam, selection) {
this.set(queryParam, serialize(selection));
}
Expand Down
1 change: 0 additions & 1 deletion ui/app/controllers/jobs/job/task-group.js
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,6 @@ export default class TaskGroupController extends Controller.extend(
return clients.sort().map(dc => ({ key: dc, label: dc }));
}

@action
setFacetQueryParam(queryParam, selection) {
this.set(queryParam, serialize(selection));
}
Expand Down
6 changes: 3 additions & 3 deletions ui/app/templates/clients/client/index.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -300,21 +300,21 @@
@label="Namespace"
@options={{this.optionsNamespace}}
@selection={{this.selectionNamespace}}
@onSelect={{action "setFacetQueryParam" "qpNamespace"}}
@onSelect={{action this.setFacetQueryParam "qpNamespace"}}
/>
<MultiSelectDropdown
data-test-allocation-job-facet
@label="Job"
@options={{this.optionsJob}}
@selection={{this.selectionJob}}
@onSelect={{action "setFacetQueryParam" "qpJob"}}
@onSelect={{action this.setFacetQueryParam "qpJob"}}
/>
<MultiSelectDropdown
data-test-allocation-status-facet
@label="Status"
@options={{this.optionsAllocationStatus}}
@selection={{this.selectionStatus}}
@onSelect={{action "setFacetQueryParam" "qpStatus"}}
@onSelect={{action this.setFacetQueryParam "qpStatus"}}
/>
<SearchBox
@searchTerm={{mut this.searchTerm}}
Expand Down
4 changes: 2 additions & 2 deletions ui/app/templates/jobs/job/task-group.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -75,14 +75,14 @@
@label="Status"
@options={{this.optionsAllocationStatus}}
@selection={{this.selectionStatus}}
@onSelect={{action "setFacetQueryParam" "qpStatus"}}
@onSelect={{action this.setFacetQueryParam "qpStatus"}}
/>
<MultiSelectDropdown
data-test-allocation-client-facet
@label="Client"
@options={{this.optionsClients}}
@selection={{this.selectionClient}}
@onSelect={{action "setFacetQueryParam" "qpClient"}}
@onSelect={{action this.setFacetQueryParam "qpClient"}}
/>
<SearchBox
@searchTerm={{mut this.searchTerm}}
Expand Down

0 comments on commit a8c9676

Please sign in to comment.