-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix race in framer and improperly returned err
Fixes #3342 Two bugs were fixed: * Closing the StreamFramer's exitCh before setting the error means other goroutines blocked on exitCh closing could see the error as nil. This was *not* observered. * parseFramerError on Windows would fall through and return an improperly captured nil err variable. There's no need for parseFramerError to be a closure which fixes the confusion.
- Loading branch information
1 parent
88cb8bb
commit ac3fffc
Showing
1 changed file
with
34 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters