Skip to content

Commit

Permalink
Fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
isabeldepapel committed Apr 23, 2021
1 parent 3a075ec commit b04f8b2
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions drivers/docker/driver_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2911,28 +2911,33 @@ func TestDockerDriver_memoryLimits(t *testing.T) {
func TestDockerDriver_parseSignal(t *testing.T) {
t.Parallel()

d := new(Driver)
// d := new(Driver)

task, _, ports := dockerTask(t)
defer freeport.Return(ports)
_, _, handle, cleanup := dockerSetup(t, task, nil)
defer cleanup()

t.Run("default", func(t *testing.T) {
s, err := d.parseSignal(runtime.GOOS, "")
s, err := handle.parseSignal(runtime.GOOS, "")
require.NoError(t, err)
require.Equal(t, syscall.SIGTERM, s)
})

t.Run("set", func(t *testing.T) {
s, err := d.parseSignal(runtime.GOOS, "SIGHUP")
s, err := handle.parseSignal(runtime.GOOS, "SIGHUP")
require.NoError(t, err)
require.Equal(t, syscall.SIGHUP, s)
})

t.Run("windows conversion", func(t *testing.T) {
s, err := d.parseSignal("windows", "SIGINT")
s, err := handle.parseSignal("windows", "SIGINT")
require.NoError(t, err)
require.Equal(t, syscall.SIGTERM, s)
})

t.Run("not a signal", func(t *testing.T) {
_, err := d.parseSignal(runtime.GOOS, "SIGDOESNOTEXIST")
_, err := handle.parseSignal(runtime.GOOS, "SIGDOESNOTEXIST")
require.Error(t, err)
})
}

0 comments on commit b04f8b2

Please sign in to comment.