add a note about node connection failure and fallback

hashicorp · May 25, 2021 · b294f63 · b294f63
1 parent a15a617
commit b294f63
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/api/allocations_exec.go b/api/allocations_exec.go
@@ -62,7 +62,12 @@ func (s *execSession) run(ctx context.Context) (exitCode int, err error) {
 }
 
 func (s *execSession) startConnection() (*websocket.Conn, error) {
-	nodeClient, _ := s.client.GetNodeClientWithTimeout(s.alloc.NodeID, ClientConnTimeout, s.q)
+	// First, attempt to connect to the node directly, but may fail due to network isolation
+	// and network errors.  Fallback to using server-side forwarding instead.
+	nodeClient, err := s.client.GetNodeClientWithTimeout(s.alloc.NodeID, ClientConnTimeout, s.q)
+	if err == NodeDownErr {
+		return nil, NodeDownErr
+	}
 
 	q := s.q
 	if q == nil {

diff --git a/vendor/github.com/hashicorp/nomad/api/allocations_exec.go b/vendor/github.com/hashicorp/nomad/api/allocations_exec.go