Skip to content

Commit

Permalink
ci: make split between e2e and integration tests explicit (#9091)
Browse files Browse the repository at this point in the history
Currently we compile (but don't run) the e2e tests as part of `test-other`,
which is skipped for branches named `e2e-*`. Move this check into the
`test-e2e` job. Split out the vault compatibility integration check as its own
makefile target for clarity.
  • Loading branch information
tgross committed Oct 14, 2020
1 parent d68e3d4 commit b2fb40e
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 2 deletions.
4 changes: 3 additions & 1 deletion .circleci/config.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .circleci/config/jobs/test-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,5 @@ steps:
chown -R circleci:circleci /go
- run: sudo -E -H -u circleci PATH=${PATH} make deps
- run: sudo -E -H -u circleci PATH=${PATH} make integration-test
- run: sudo -E -H -u circleci PATH=${PATH} make e2e-test
2 changes: 1 addition & 1 deletion .circleci/config/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
filters: *backend_test_branches_filter
- test-machine:
name: "test-other"
exclude_packages: "./api|./client|./drivers/docker|./drivers/exec|./drivers/shared/executor|./nomad|./devices"
exclude_packages: "./api|./client|./drivers/docker|./drivers/exec|./drivers/shared/executor|./nomad|./devices|./e2e"
filters: *backend_test_branches_filter
- test-machine:
name: "test-docker"
Expand Down
9 changes: 9 additions & 0 deletions GNUmakefile
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,15 @@ test-nomad-module: dev ## Run Nomad test suites on a sub-module
.PHONY: e2e-test
e2e-test: dev ## Run the Nomad e2e test suite
@echo "==> Running Nomad E2E test suites:"
go test \
$(if $(ENABLE_RACE),-race) $(if $(VERBOSE),-v) \
-timeout=900s \
-tags "$(GO_TAGS)" \
github.com/hashicorp/nomad/e2e

.PHONY: integration-test
integration-test: dev ## Run Nomad integration tests
@echo "==> Running Nomad integration test suites:"
go test \
$(if $(ENABLE_RACE),-race) $(if $(VERBOSE),-v) \
-cover \
Expand Down

0 comments on commit b2fb40e

Please sign in to comment.