apply code review

hashicorp · Jun 20, 2023 · b62d43b · b62d43b
1 parent b99e8c5
commit b62d43b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/scheduler/scheduler_system.go b/scheduler/scheduler_system.go
@@ -162,7 +162,7 @@ func (s *SystemScheduler) process() (bool, error) {
 		// which values to use.
 		pool, err := s.state.NodePoolByName(ws, s.job.NodePool)
 		if err != nil {
-			return false, fmt.Errorf("failed to get job node pool '%s': %v", s.job.NodePool, err)
+			return false, fmt.Errorf("failed to get job node pool %q: %v", s.job.NodePool, err)
 		}
 		_, schedConfig, err := s.state.SchedulerConfig()
 		if err != nil {

diff --git a/scheduler/scheduler_test.go b/scheduler/scheduler_test.go
@@ -42,7 +42,9 @@ func TestScheduler_JobRegister_MemoryMaxHonored(t *testing.T) {
 		memoryOversubscriptionEnabled bool
 
 		expectedTaskMemoryMax int
-		// expectedTotalMemoryMax should be SUM(MAX(memory, memoryMax)) for all tasks
+		// expectedTotalMemoryMax should be SUM(MAX(memory, memoryMax)) for all
+		// tasks if memory oversubscription is enabled and SUM(memory) if it's
+		// disabled.
 		expectedTotalMemoryMax int
 	}{
 		{