Changes from code review

hashicorp · Feb 11, 2019 · b769365 · b769365
1 parent 2fdec7e
commit b769365
Showing 1 changed file with 11 additions and 11 deletions.
diff --git a/ui/app/controllers/jobs/index.js b/ui/app/controllers/jobs/index.js
@@ -51,6 +51,16 @@ export default Controller.extend(Sortable, Searchable, {
   fuzzySearchProps: computed(() => ['name']),
   fuzzySearchEnabled: true,
 
+  qpType: '',
+  qpStatus: '',
+  qpDatacenter: '',
+  qpPrefix: '',
+
+  selectionType: qpSelection('qpType'),
+  selectionStatus: qpSelection('qpStatus'),
+  selectionDatacenter: qpSelection('qpDatacenter'),
+  selectionPrefix: qpSelection('qpPrefix'),
+
   optionsType: computed(() => [
     { key: 'batch', label: 'Batch' },
     { key: 'parameterized', label: 'Parameterized' },
@@ -125,18 +135,8 @@ export default Controller.extend(Sortable, Searchable, {
     }));
   }),
 
-  qpType: '',
-  qpStatus: '',
-  qpDatacenter: '',
-  qpPrefix: '',
-
-  selectionType: qpSelection('qpType'),
-  selectionStatus: qpSelection('qpStatus'),
-  selectionDatacenter: qpSelection('qpDatacenter'),
-  selectionPrefix: qpSelection('qpPrefix'),
-
   /**
-    Filtered jobs are those that match the selected namespace and aren't children
+    Visible jobs are those that match the selected namespace and aren't children
     of periodic or parameterized jobs.
   */
   visibleJobs: computed('model.[]', 'model.@each.parent', function() {