-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c4fd236
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that the agent HCL config file should look something like this?:
c4fd236
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ErikEvenson: No it would look like:
c4fd236
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @dadgar -- I would not have tried that structure. I updated to this structure but my nomad still doesn't seem to use the auths in my
config.json
file to access my private registry. I'm using Nomad v0.3.0-rc1 (5e1a3c6+CHANGES) and Docker version 1.10.1, build 9e83765.c4fd236
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ErikEvenson How does your nomad client configuration look like?
c4fd236
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use this in a setup script:
where
nomad-config.hcl
is:c4fd236
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I aslo tried a
nomad-config.hcl
of:with no change in results.
c4fd236
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ErikEvenson Can you please build Nomad form master and see what happens? We were not logging any errors ealier so in case Nomad wasn;t able to read the auth config file it won't error, however with the changes I made the docker driver is going to throw an error if the operator wants to use a config file but Nomad wasn't able to read it.
c4fd236
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diptanu ok -- I am running the master branch. Two questions: 1) which is correct above,
docker.auth_config
ordocker.auth.config
. 2) Should I be looking in the docker.log or the nomad output for an error?c4fd236
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ErikEvenson Please use
docker.auth.config
as the key in the client options. And the error would be in Nomad logs.c4fd236
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using Nomad v0.3.0-rc1 (1d9c65b) these are my nomad logs:
c4fd236
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is
/home/docker/nomad-config.hcl
:and here is a redacted
config.json
:c4fd236
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ErikEvenson Can you please remove the
https
from thehttps://212181198242.dkr.ecr.us-east-1.amazonaws.com
in the config.json? Or alternatively in your image configuration in the nomad job spec can you specifyhttps://212181198242.dkr.ecr.us-east-1.amazonaws.com/vbenergy/vbez-web:2016.02.19.0
instead of212181198242.dkr.ecr.us-east-1.amazonaws.com/vbenergy/vbez-web:2016.02.19.0
In the code, we are doing a map lookup to find out the authConfiguration, so that might be the problem.
c4fd236
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the image configuration in my job spec led to:
Removing the https in the
config.json
led to:c4fd236
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ErikEvenson Ok I am going to launch a ECR myself now and test this on AWS myself. Thanks for helping to debug this, I will report here what I find out
c4fd236
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diptanu -- thanks for your attention on this! Using ECR would be an important feature for us.
c4fd236
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diptanu do you think this will get addressed in 0.3.0?
c4fd236
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ErikEvenson Not yet, hopefully going to get it on 0.3.1