Improve port label validation and diff testing

hashicorp · Dec 8, 2017 · c68ed09 · c68ed09
1 parent b731f7f
commit c68ed09
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/nomad/structs/diff_test.go b/nomad/structs/diff_test.go
@@ -3507,6 +3507,12 @@ func TestTaskDiff(t *testing.T) {
 								Type: DiffTypeEdited,
 								Name: "Check",
 								Fields: []*FieldDiff{
+									{
+										Type: DiffTypeNone,
+										Name: "AddressMode",
+										Old:  "",
+										New:  "",
+									},
 									{
 										Type: DiffTypeNone,
 										Name: "Command",

diff --git a/nomad/structs/structs.go b/nomad/structs/structs.go
@@ -3473,10 +3473,14 @@ func validateServices(t *Task) error {
 		knownServices[service.Name+service.PortLabel] = struct{}{}
 
 		if service.PortLabel != "" {
-			if _, err := strconv.Atoi(service.PortLabel); service.AddressMode == "driver" && err == nil {
-				// Numeric ports are valid when AddressMode=driver
+			if service.AddressMode == "driver" {
+				// Numeric port labels are valid for address_mode=driver
+				_, err := strconv.Atoi(service.PortLabel)
+				if err != nil {
+					// Not a numeric port label, add it to list to check
+					servicePorts[service.PortLabel] = append(servicePorts[service.PortLabel], service.Name)
+				}
 			} else {
-
 				servicePorts[service.PortLabel] = append(servicePorts[service.PortLabel], service.Name)
 			}
 		}