Skip to content

Commit

Permalink
build: load time/tzdata on Windows (#18676)
Browse files Browse the repository at this point in the history
Nomad uses `time.LoadLocation()` to translate a periodic job time zone
string value to a `time.Location`. From godocs:

    LoadLocation looks for the IANA Time Zone database in the following locations in order:

    * the directory or uncompressed zip file named by the ZONEINFO environment variable
    * on a Unix system, the system standard installation location
    * $GOROOT/lib/time/zoneinfo.zip
    * the time/tzdata package, if it was imported

So non-Unix systems require Go to be installed or `time/tzdata` to be
imported, otherwise running periodic jobs with a specific `time_zone`
value results in an error:

    Invalid time zone "America/Toronto": unknown time zone America/Toronto

This commit adds the `timetzdata` build tag on Windows to embed the time
zone data into the final binary. This results in a slightly bigger
binary, but from `time/tzdata` godocs:

    Importing this package will increase the size of a program by about 450 KB.
    [..]
    This package will be automatically imported if you build with -tags timetzdata.
  • Loading branch information
lgfa29 committed Oct 6, 2023
1 parent 597d835 commit c6ce966
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .changelog/18676.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
build: Add `timetzdata` Go build tag on Windows binaries to embed time zone data so periodic jobs are able to specify a time zone value on Windows environments
```
1 change: 1 addition & 0 deletions GNUmakefile
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ pkg/linux_%/nomad: CGO_ENABLED = 0
endif

pkg/windows_%/nomad: GO_OUT = $@.exe
pkg/windows_%/nomad: GO_TAGS += timetzdata

# Define package targets for each of the build targets we actually have on this system
define makePackageTarget
Expand Down

0 comments on commit c6ce966

Please sign in to comment.