Fix goroutine leakage (#15180)

* Fix goroutine leakage * cl: add cl entry Co-authored-by: Seth Hoenig <shoenig@duck.com>
hashicorp · Nov 17, 2022 · d16a2c9 · d16a2c9
1 parent 732adae
commit d16a2c9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/.changelog/15180.txt b/.changelog/15180.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+drivers: Fixed a bug where one goroutine was leaked per task
+```
diff --git a/plugins/drivers/client.go b/plugins/drivers/client.go
@@ -187,7 +187,8 @@ func (d *driverPluginClient) handleWaitTask(ctx context.Context, id string, ch c
 	}
 
 	// Join the passed context and the shutdown context
-	joinedCtx, _ := joincontext.Join(ctx, d.doneCtx)
+	joinedCtx, joinedCtxCancel := joincontext.Join(ctx, d.doneCtx)
+	defer joinedCtxCancel()
 
 	resp, err := d.client.WaitTask(joinedCtx, req)
 	if err != nil {