Fix error handling in Client consulDiscoveryImpl (#14431)

Added a missing `continue` on non-nil error to avoid accidentally using a bad peer.
hashicorp · Sep 2, 2022 · df043d7 · df043d7
1 parent 7d88937
commit df043d7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/.changelog/14431.txt b/.changelog/14431.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+client: Fixed bug where clients could attempt to connect to servers with invalid addresses retrieved from Consul.
+```
diff --git a/client/client.go b/client/client.go
@@ -2869,6 +2869,7 @@ DISCOLOOP:
 				addr, err := net.ResolveTCPAddr("tcp", p)
 				if err != nil {
 					mErr.Errors = append(mErr.Errors, err)
+					continue
 				}
 				srv := &servers.Server{Addr: addr}
 				nomadServers = append(nomadServers, srv)