Merge fef719c into backport/docker-pause-tracker-config/separately-cl…

…assic-boxer

.changelog/16713.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+docker: Fixed a bug where plugin config values were ignored
+```

drivers/docker/config.go

@@ -204,7 +204,7 @@ var (
 			"type":   hclspec.NewAttr("type", "string", false),
 			"config": hclspec.NewBlockAttrs("config", "string", false),
 		})), hclspec.NewLiteral(`{
-			type = "json-file" 
+			type = "json-file"
 			config = {
 				max-file = "2"
 				max-size = "2m"
@@ -771,6 +771,8 @@ func (d *Driver) SetConfig(c *base.Config) error {
 
 	d.cpusetFixer = newCpusetFixer(d)
 
+	go d.recoverPauseContainers(d.ctx)
+
 	return nil
 }
 

drivers/docker/driver.go

@@ -171,7 +171,7 @@ func NewDockerDriver(ctx context.Context, logger hclog.Logger) drivers.DriverPlu
 		ctx:             ctx,
 		logger:          logger,
 	}
-	go driver.recoverPauseContainers(ctx)
+
 	return driver
 }
 
@@ -748,11 +748,11 @@ func (d *Driver) containerBinds(task *drivers.TaskConfig, driverConfig *TaskConf
 	return binds, nil
 }
 
+// recoverPauseContainers gets called when we start up the plugin. On client
+// restarts we need to rebuild the set of pause containers we are
+// tracking. Basically just scan all containers and pull the ID from anything
+// that has the Nomad Label and has Name with prefix "/nomad_init_".
 func (d *Driver) recoverPauseContainers(ctx context.Context) {
-	// On Client restart, we must rebuild the set of pause containers
-	// we are tracking. Basically just scan all containers and pull the ID from
-	// anything that has the Nomad Label and has Name with prefix "/nomad_init_".
-
 	_, dockerClient, err := d.dockerClients()
 	if err != nil {
 		d.logger.Error("failed to recover pause containers", "error", err)
@@ -766,8 +766,8 @@ func (d *Driver) recoverPauseContainers(ctx context.Context) {
 			"label": {dockerLabelAllocID},
 		},
 	})
-	if listErr != nil {
-		d.logger.Error("failed to list pause containers", "error", err)
+	if listErr != nil && listErr != ctx.Err() {
+		d.logger.Error("failed to list pause containers", "error", listErr)
 		return
 	}