Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
eval broker test: enable canceled eval reaper
Following the update to the go1.20 toolchain, the eval broker integration test started to become flaky. The `Eval.Ack` RPC never blocks when trying to wake up `reapCancelableEvaluations` because the reaper has a periodic timer that ensures the evals will get reaped eventually. With the reaper effectively disabled in the test, it's possible for the eval broker to ack the two ready evals before the reaper goroutine ever gets scheduled, at which point the cancelable evals won't get reaped in this test. The test was always wrong in this sense, but the toolchain update seems to have changed the timing enough that it now fails frequently. This changeset also adjusts the timeout and reduces the number of concurrent schedulers to reduce contention on the eval broker's lock during the test. The test has been updated to use `shoenig/test/wait` so we can have sensible reporting of the results rather than just a timeout error when things go wrong. This is how I verified that the eval broker's internal logic was still correct and that the problem was just the reaper not running.
- Loading branch information