-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* button styles * Further styles including global toggle adjustment * sidebar funcs and header * Functioning task logs in high-level sidebars * same-lineify the show tasks toggle * Changelog * Full-height sidebar calc in css, plz drop soon container queries * Active status and query params for allocations page * Reactive shouldShowLogs getter and added to client and task group pages * Higher order func passing, thanks @DingoEatingFuzz * Non-service job types get allocation params passed * Keyframe animation for task log sidebar * Acceptance test * A few more sub-row tests * Lintfix
- Loading branch information
1 parent
d1e90a1
commit e4b763f
Showing
33 changed files
with
342 additions
and
44 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
```release-note:improvement | ||
ui: adds a sidebar to show in-page logs for a given task, accessible via job, client, or task group routes | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
<Portal @target="log-sidebar-portal"> | ||
<div | ||
class="sidebar task-context-sidebar has-subnav {{if this.isSideBarOpen "open"}}" | ||
{{on-click-outside | ||
@fns.closeSidebar | ||
capture=true | ||
}} | ||
> | ||
{{#if @task}} | ||
{{keyboard-commands this.keyCommands}} | ||
<header> | ||
<h1 class="title"> | ||
{{@task.name}} | ||
<span class="state {{@task.state}}"> | ||
{{@task.state}} | ||
</span> | ||
</h1> | ||
<LinkTo | ||
class="link" | ||
title={{@task.name}} | ||
@route="allocations.allocation.task" | ||
@models={{array @task.allocation @task}} | ||
> | ||
Go to Task page | ||
</LinkTo> | ||
<button | ||
class="button close is-borderless" | ||
type="button" | ||
{{on "click" @fns.closeSidebar}} | ||
> | ||
{{x-icon "cancel"}} | ||
</button> | ||
</header> | ||
|
||
<TaskLog | ||
@allocation={{@task.allocation}} | ||
@task={{@task.name}} | ||
@shouldFillHeight={{false}} | ||
/> | ||
|
||
|
||
{{/if}} | ||
</div> | ||
</Portal> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
// @ts-check | ||
import Component from '@glimmer/component'; | ||
|
||
export default class TaskContextSidebarComponent extends Component { | ||
get isSideBarOpen() { | ||
return !!this.args.task; | ||
} | ||
|
||
keyCommands = [ | ||
{ | ||
label: 'Close Task Logs Sidebar', | ||
pattern: ['Escape'], | ||
action: () => this.args.fns.closeSidebar(), | ||
}, | ||
]; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,6 +26,9 @@ | |
.is-padded { | ||
padding: 0em 0em 0em 1em; | ||
} | ||
.is-one-line { | ||
white-space: nowrap; | ||
} | ||
} | ||
|
||
.is-fixed-width { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.