Chronological most-recent evals by default (#12847)

* Chronological most-recent evals by default * Adding reverse: true to the list of expected queryparams in test * changelog
hashicorp · May 5, 2022 · f1fdca5 · f1fdca5
1 parent f34938d
commit f1fdca5
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 0 deletions.
diff --git a/.changelog/12847.txt b/.changelog/12847.txt
@@ -0,0 +1,3 @@
+```release-note:improvement
+ui: change sort-order of evaluations to be reverse-chronological
+```
diff --git a/ui/app/routes/evaluations/index.js b/ui/app/routes/evaluations/index.js
@@ -94,6 +94,7 @@ export default class EvaluationsIndexRoute extends Route {
 
     return this.store.query('evaluation', {
       namespace,
+      reverse: true,
       per_page: pageSize,
       next_token: nextToken,
       filter: generateFilterExpression(),

diff --git a/ui/tests/acceptance/evaluations-test.js b/ui/tests/acceptance/evaluations-test.js
@@ -147,6 +147,7 @@ module('Acceptance | evaluations list', function (hooks) {
           per_page: '25',
           next_token: '',
           filter: '',
+          reverse: 'true',
         },
         'Forwards the correct query parameters on default query when route initially loads'
       );
@@ -181,6 +182,7 @@ module('Acceptance | evaluations list', function (hooks) {
             per_page: '25',
             next_token: '',
             filter: 'Status contains "pending"',
+            reverse: 'true',
           },
           'It makes another server request using the options selected by the user'
         );
@@ -210,6 +212,7 @@ module('Acceptance | evaluations list', function (hooks) {
             per_page: '25',
             next_token: '',
             filter: '',
+            reverse: 'true',
           },
           'It makes another server request using the options selected by the user'
         );
@@ -239,6 +242,7 @@ module('Acceptance | evaluations list', function (hooks) {
             per_page: '25',
             next_token: '',
             filter: `TriggeredBy contains "periodic-job"`,
+            reverse: 'true',
           },
           'It makes another server request using the options selected by the user'
         );
@@ -271,6 +275,7 @@ module('Acceptance | evaluations list', function (hooks) {
             per_page: '25',
             next_token: '',
             filter: 'NodeID is not empty',
+            reverse: 'true',
           },
           'It makes another server request using the options selected by the user'
         );
@@ -301,6 +306,7 @@ module('Acceptance | evaluations list', function (hooks) {
             per_page: '25',
             next_token: '',
             filter: `ID contains "${searchTerm}" or JobID contains "${searchTerm}" or NodeID contains "${searchTerm}" or TriggeredBy contains "${searchTerm}"`,
+            reverse: 'true',
           },
           'It makes another server request using the options selected by the user'
         );
@@ -330,6 +336,7 @@ module('Acceptance | evaluations list', function (hooks) {
             per_page: '25',
             next_token: '',
             filter: `ID contains "${searchTerm}" or JobID contains "${searchTerm}" or NodeID contains "${searchTerm}" or TriggeredBy contains "${searchTerm}"`,
+            reverse: 'true',
           },
           'It makes another server request using the options selected by the user'
         );
@@ -345,6 +352,7 @@ module('Acceptance | evaluations list', function (hooks) {
             per_page: '25',
             next_token: '',
             filter: `(ID contains "${searchTerm}" or JobID contains "${searchTerm}" or NodeID contains "${searchTerm}" or TriggeredBy contains "${searchTerm}") and NodeID is not empty`,
+            reverse: 'true',
           },
           'It makes another server request using the options selected by the user'
         );
@@ -361,6 +369,7 @@ module('Acceptance | evaluations list', function (hooks) {
             per_page: '25',
             next_token: '',
             filter: `NodeID is not empty`,
+            reverse: 'true',
           },
           'It makes another server request using the options selected by the user'
         );
@@ -376,6 +385,7 @@ module('Acceptance | evaluations list', function (hooks) {
             per_page: '25',
             next_token: '',
             filter: `NodeID is not empty and Status contains "complete"`,
+            reverse: 'true',
           },
           'It makes another server request using the options selected by the user'
         );
@@ -412,6 +422,7 @@ module('Acceptance | evaluations list', function (hooks) {
             per_page: '50',
             next_token: '',
             filter: '',
+            reverse: 'true',
           },
           'It makes a request with the per_page set by the user'
         );
@@ -445,6 +456,7 @@ module('Acceptance | evaluations list', function (hooks) {
             per_page: '25',
             next_token: 'next-token-1',
             filter: '',
+            reverse: 'true',
           },
           'It makes another server request using the options selected by the user'
         );
@@ -470,6 +482,7 @@ module('Acceptance | evaluations list', function (hooks) {
             per_page: '25',
             next_token: 'next-token-2',
             filter: '',
+            reverse: 'true',
           },
           'It makes another server request using the options selected by the user'
         );
@@ -495,6 +508,7 @@ module('Acceptance | evaluations list', function (hooks) {
             per_page: '25',
             next_token: 'next-token-1',
             filter: '',
+            reverse: 'true',
           },
           'It makes a request using the stored old token.'
         );
@@ -515,6 +529,7 @@ module('Acceptance | evaluations list', function (hooks) {
             per_page: '25',
             next_token: '',
             filter: '',
+            reverse: 'true',
           },
           'When there are no more stored previous tokens, we will request with no next-token.'
         );
@@ -558,6 +573,7 @@ module('Acceptance | evaluations list', function (hooks) {
             per_page: '25',
             next_token: '',
             filter: '',
+            reverse: 'true',
           },
           'It clears all query parameters when making a refresh'
         );
@@ -605,6 +621,7 @@ module('Acceptance | evaluations list', function (hooks) {
             per_page: '25',
             next_token: '',
             filter: 'Status contains "pending"',
+            reverse: 'true',
           },
           'It clears all next token when filtered request is made'
         );