Review addressed and changlog added

hashicorp · Jul 29, 2023 · f274147 · f274147
1 parent e7232d3
commit f274147
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/.changelog/17958.txt b/.changelog/17958.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+cli: make snapshot name requiered in creating volume snapshots
+```
diff --git a/command/volume_snapshot_create.go b/command/volume_snapshot_create.go
@@ -19,7 +19,7 @@ type VolumeSnapshotCreateCommand struct {
 
 func (c *VolumeSnapshotCreateCommand) Help() string {
 	helpText := `
-Usage: nomad volume snapshot create <volume id> snapshot_name
+Usage: nomad volume snapshot create <volume id> <snapshot_name>
 
   Create a snapshot of an external storage volume. This command requires a
   volume ID or prefix and snapthost name. If there is an exact match based on
@@ -99,8 +99,8 @@ func (c *VolumeSnapshotCreateCommand) Run(args []string) int {
 
 	// Check that we at least one argument
 	args = flags.Args()
-	if l := len(args); l <= 1 {
-		c.Ui.Error("This command takes two argument: <vol id> <snapshot name>")
+	if l := len(args); l != 2 {
+		c.Ui.Error("This command takes two arguments: <vol id> <snapshot name>")
 		c.Ui.Error(commandErrorText(c))
 		return 1
 	}