Skip to content

Commit

Permalink
[ui] Reinstate Meta and Payload sections to Parameterized Child Jobs (#…
Browse files Browse the repository at this point in the history
…13473)

* Shift meta off job.definition and decodedPayload alias to passed arg

* Changelog
  • Loading branch information
philrenaud committed Jun 24, 2022
1 parent cea3a3d commit f5b8506
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
3 changes: 3 additions & 0 deletions .changelog/13473.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
ui: Fixed a bug where dispatched children of parameterized jobs wouldn't display metadata or payloads
``
2 changes: 1 addition & 1 deletion ui/app/components/job-page/parameterized-child.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { alias } from '@ember/object/computed';
import Component from '@glimmer/component';

export default class ParameterizedChild extends Component {
@alias('job.decodedPayload') payload;
@alias('args.job.decodedPayload') payload;

@computed('payload')
get payloadJSON() {
Expand Down
8 changes: 4 additions & 4 deletions ui/app/templates/components/job-page/parameterized-child.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,12 @@
<jobPage.ui.TaskGroups @sortProperty={{@sortProperty}} @sortDescending={{@sortDescending}} />
<jobPage.ui.RecentAllocations />
<div class="boxed-section">
<div class="boxed-section-head">
Meta
</div>
{{#if @job.definition.Meta}}
{{#if @job.meta}}
<jobPage.ui.Meta />
{{else}}
<div class="boxed-section-head">
Meta
</div>
<div class="boxed-section-body">
<div data-test-empty-meta-message class="empty-message">
<h3 class="empty-message-headline">
Expand Down

0 comments on commit f5b8506

Please sign in to comment.