address review comments

hashicorp · Dec 13, 2019 · ff05434 · ff05434
1 parent 9438544
commit ff05434
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/client/allocrunner/taskrunner/logmon_hook.go b/client/allocrunner/taskrunner/logmon_hook.go
@@ -104,7 +104,7 @@ func (h *logmonHook) Prestart(ctx context.Context,
 	req *interfaces.TaskPrestartRequest, resp *interfaces.TaskPrestartResponse) error {
 
 	if h.isLoggingDisabled() {
-		h.logger.Info("logging is disabled by driver")
+		h.logger.Debug("logging is disabled by driver")
 		return nil
 	}
 

diff --git a/drivers/docker/config.go b/drivers/docker/config.go
@@ -258,6 +258,8 @@ var (
 			hclspec.NewLiteral(`"gcr.io/google_containers/pause-amd64:3.0"`),
 		),
 
+		// disable_log_colleciton indicates whether docker driver should collect logs of docker
+		// task containers.  If true, nomad doesn't start docker_logger/logmon processes
 		"disable_log_collection": hclspec.NewAttr("disable_log_collection", "bool", false),
 	})